From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: veeraiyan chidambaram <external.veeraiyan.c@de.adit-jv.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
"REE erosca@DE.ADIT-JV.COM" <erosca@DE.ADIT-JV.COM>,
Veeraiyan Chidambaram <veeraiyan.chidambaram@in.bosch.com>
Subject: RE: [PATCH v4 2/3] usb: renesas_usbhs: enable DVSE interrupt
Date: Wed, 11 Sep 2019 02:45:52 +0000 [thread overview]
Message-ID: <TYAPR01MB45447960B4D77CB0C01B08BBD8B10@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190910093117.GB9960@vmlxhi-070.adit-jv.com>
Hello Veeraiyan-san,
> From: veeraiyan chidambaram, Sent: Tuesday, September 10, 2019 6:31 PM
>
> Hello shimoda-san,
>
> Thanks for point out checkpatch warning. After resolving checkpatch warning,
> below checkpatch warning is seen.
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #23:
> [1] commit f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")
I checked other commit log, and it seems adding a new line is better like below:
[1] commit f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common
code")
JFYI (out-of-topic though), checkpatch.pl doesn't warn if a "Fixes:" tag with
more than 75 chars like following commit [2].
[2]
---
commit d950fd992ef89f39ff8908f389ed6cbd2fdc0513
Author: Niklas Söderlund <***>
Date: Wed Feb 13 17:07:54 2019 -0500
media: rcar-vin: Fix lockdep warning at stream on
Changes to v4l2-fwnode in commit [1] triggered a lockdep warning in
rcar-vin. The first attempt to solve this warning in the rcar-vin driver
was incomplete and only pushed the warning to happen at stream on time
instead of at probe time.
This change reverts the incomplete fix and properly fixes the warning by
removing the need to hold the rcar-vin specific group lock when calling
v4l2_async_notifier_parse_fwnode_endpoints_by_port(). And instead takes
it in the callback where it's really needed.
[1] commit eae2aed1eab9bf08 ("media: v4l2-fwnode: Switch to
v4l2_async_notifier_add_subdev")
Fixes: 6458afc8c49148f0 ("media: rcar-vin: remove unneeded locking in async callbacks")
<snip>
---
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2019-09-11 2:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 15:46 [PATCH v4 1/3] usb: renesas_usbhs: simplify usbhs_status_get_device_state() Veeraiyan Chidambaram
2019-09-09 15:46 ` [PATCH v4 2/3] usb: renesas_usbhs: enable DVSE interrupt Veeraiyan Chidambaram
2019-09-10 4:45 ` Yoshihiro Shimoda
2019-09-10 9:31 ` veeraiyan chidambaram
2019-09-11 2:45 ` Yoshihiro Shimoda [this message]
2019-09-11 13:22 ` veeraiyan chidambaram
2019-09-09 15:46 ` [PATCH v4 3/3] usb: renesas_usbhs: add suspend event support in gadget mode Veeraiyan Chidambaram
2019-09-10 4:47 ` Yoshihiro Shimoda
2019-09-10 4:41 ` [PATCH v4 1/3] usb: renesas_usbhs: simplify usbhs_status_get_device_state() Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB45447960B4D77CB0C01B08BBD8B10@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=andrew_gabbasov@mentor.com \
--cc=balbi@kernel.org \
--cc=erosca@DE.ADIT-JV.COM \
--cc=external.veeraiyan.c@de.adit-jv.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=veeraiyan.chidambaram@in.bosch.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).