* [PATCH] ARM: shmobile: defconfig: Resotre support for V4L2 platform devices
@ 2020-07-04 15:47 Niklas Söderlund
2020-07-04 16:56 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Söderlund @ 2020-07-04 15:47 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: Niklas Söderlund
Since commit [1] the Renesas V4L2 platform devices are no longer enabled
with the shmobile_defconfig, restore functionality by enabling
MEDIA_PLATFORM_SUPPORT.
1. b0cd4fb276653f8f ("media: Kconfig: on !EMBEDDED && !EXPERT, enable driver filtering")
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 9cf3143025e1eea4..c14612fc06767621 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -112,6 +112,7 @@ CONFIG_MEDIA_SUPPORT=y
CONFIG_MEDIA_CAMERA_SUPPORT=y
CONFIG_MEDIA_CONTROLLER=y
CONFIG_VIDEO_V4L2_SUBDEV_API=y
+CONFIG_MEDIA_PLATFORM_SUPPORT=y
CONFIG_V4L_PLATFORM_DRIVERS=y
CONFIG_VIDEO_RCAR_VIN=y
CONFIG_V4L_MEM2MEM_DRIVERS=y
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: shmobile: defconfig: Resotre support for V4L2 platform devices
2020-07-04 15:47 [PATCH] ARM: shmobile: defconfig: Resotre support for V4L2 platform devices Niklas Söderlund
@ 2020-07-04 16:56 ` Geert Uytterhoeven
2020-07-05 8:49 ` Niklas Söderlund
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-07-04 16:56 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: Linux-Renesas
Hi Niklas,
Thanks for your patch!
On Sat, Jul 4, 2020 at 5:49 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Since commit [1] the Renesas V4L2 platform devices are no longer enabled
> with the shmobile_defconfig, restore functionality by enabling
> MEDIA_PLATFORM_SUPPORT.
>
> 1. b0cd4fb276653f8f ("media: Kconfig: on !EMBEDDED && !EXPERT, enable driver filtering")
I thought it was needed since commit 06b93644f4d102bd ("media: Kconfig:
add an option to filter in/out platform drivers")).
This is a minor detail, though.
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -112,6 +112,7 @@ CONFIG_MEDIA_SUPPORT=y
> CONFIG_MEDIA_CAMERA_SUPPORT=y
> CONFIG_MEDIA_CONTROLLER=y
> CONFIG_VIDEO_V4L2_SUBDEV_API=y
> +CONFIG_MEDIA_PLATFORM_SUPPORT=y
> CONFIG_V4L_PLATFORM_DRIVERS=y
> CONFIG_VIDEO_RCAR_VIN=y
> CONFIG_V4L_MEM2MEM_DRIVERS=y
Already fixed in renesas-devel since commit 835a056da6409ec7 ("ARM:
shmobile: defconfig: Refresh for v5.8-rc1").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: shmobile: defconfig: Resotre support for V4L2 platform devices
2020-07-04 16:56 ` Geert Uytterhoeven
@ 2020-07-05 8:49 ` Niklas Söderlund
0 siblings, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2020-07-05 8:49 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux-Renesas
Hi Geert,
On 2020-07-04 18:56:06 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> Thanks for your patch!
>
> On Sat, Jul 4, 2020 at 5:49 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > Since commit [1] the Renesas V4L2 platform devices are no longer enabled
> > with the shmobile_defconfig, restore functionality by enabling
> > MEDIA_PLATFORM_SUPPORT.
> >
> > 1. b0cd4fb276653f8f ("media: Kconfig: on !EMBEDDED && !EXPERT, enable driver filtering")
>
> I thought it was needed since commit 06b93644f4d102bd ("media: Kconfig:
> add an option to filter in/out platform drivers")).
> This is a minor detail, though.
It might have had as many points of failure as the "feature" trusted
upon us new use-cases :-) I did not investigate further then my bisect
script run between v5.7 and v5.8-rc3.
>
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -112,6 +112,7 @@ CONFIG_MEDIA_SUPPORT=y
> > CONFIG_MEDIA_CAMERA_SUPPORT=y
> > CONFIG_MEDIA_CONTROLLER=y
> > CONFIG_VIDEO_V4L2_SUBDEV_API=y
> > +CONFIG_MEDIA_PLATFORM_SUPPORT=y
> > CONFIG_V4L_PLATFORM_DRIVERS=y
> > CONFIG_VIDEO_RCAR_VIN=y
> > CONFIG_V4L_MEM2MEM_DRIVERS=y
>
> Already fixed in renesas-devel since commit 835a056da6409ec7 ("ARM:
> shmobile: defconfig: Refresh for v5.8-rc1").
Awesome, sorry for the noise.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-05 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 15:47 [PATCH] ARM: shmobile: defconfig: Resotre support for V4L2 platform devices Niklas Söderlund
2020-07-04 16:56 ` Geert Uytterhoeven
2020-07-05 8:49 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).