* [PATCH v3] dt-bindings: media: imx274: Convert to json-schema
@ 2020-08-24 10:58 Jacopo Mondi
2020-08-28 22:12 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Jacopo Mondi @ 2020-08-24 10:58 UTC (permalink / raw)
To: robh+dt, devicetree, linux-media, Leon Luo
Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
laurent.pinchart, linux-renesas-soc
Convert the imx274 bindings document to json-schema and update
the MAINTAINERS file accordingly.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
.../devicetree/bindings/media/i2c/imx274.txt | 38 -----------
.../bindings/media/i2c/sony,imx274.yaml | 68 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 69 insertions(+), 39 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
deleted file mode 100644
index 0727079d2410..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
+++ /dev/null
@@ -1,38 +0,0 @@
-* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
-
-The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
-an active array size of 3864H x 2202V. It is programmable through I2C
-interface. The I2C address is fixed to 0x1a as per sensor data sheet.
-Image data is sent through MIPI CSI-2, which is configured as 4 lanes
-at 1440 Mbps.
-
-
-Required Properties:
-- compatible: value should be "sony,imx274" for imx274 sensor
-- reg: I2C bus address of the device
-
-Optional Properties:
-- reset-gpios: Sensor reset GPIO
-- clocks: Reference to the input clock.
-- clock-names: Should be "inck".
-- VANA-supply: Sensor 2.8v analog supply.
-- VDIG-supply: Sensor 1.8v digital core supply.
-- VDDL-supply: Sensor digital IO 1.2v supply.
-
-The imx274 device node should contain one 'port' child node with
-an 'endpoint' subnode. For further reading on port node refer to
-Documentation/devicetree/bindings/media/video-interfaces.txt.
-
-Example:
- sensor@1a {
- compatible = "sony,imx274";
- reg = <0x1a>;
- #address-cells = <1>;
- #size-cells = <0>;
- reset-gpios = <&gpio_sensor 0 0>;
- port {
- sensor_out: endpoint {
- remote-endpoint = <&csiss_in>;
- };
- };
- };
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
new file mode 100644
index 000000000000..7ae47a614d2e
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
+
+maintainers:
+ - Leon Luo <leonl@leopardimaging.com>
+
+description: -|
+ The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
+ active array size of 3864H x 2202V. It is programmable through I2C interface.
+ Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
+ Mbps.
+
+properties:
+ compatible:
+ const: sony,imx274
+
+ reg:
+ const: 0x1a
+
+ reset-gpios:
+ maxItems: 1
+
+ port:
+ type: object
+ description: |
+ The device node must contain one 'port' child node for its digital output
+ video port, in accordance with the video interface bindings defined in
+ Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+ properties:
+ endpoint:
+ type: object
+ properties:
+ remote-endpoint:
+ description: A phandle to the bus receiver's endpoint node.
+
+ additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - port
+
+examples:
+ - |
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ imx274: camera-sensor@1a {
+ compatible = "sony,imx274";
+ reg = <0x1a>;
+ reset-gpios = <&gpio_sensor 0 0>;
+
+ port {
+ sensor_out: endpoint {
+ remote-endpoint = <&csiss_in>;
+ };
+ };
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 9503ea17aa28..dc7b1ea8e7b3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16125,7 +16125,7 @@ M: Leon Luo <leonl@leopardimaging.com>
L: linux-media@vger.kernel.org
S: Maintained
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/i2c/imx274.txt
+F: Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
F: drivers/media/i2c/imx274.c
SONY IMX290 SENSOR DRIVER
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: media: imx274: Convert to json-schema
2020-08-24 10:58 [PATCH v3] dt-bindings: media: imx274: Convert to json-schema Jacopo Mondi
@ 2020-08-28 22:12 ` Rob Herring
2020-08-29 10:04 ` Jacopo Mondi
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-08-28 22:12 UTC (permalink / raw)
To: Jacopo Mondi
Cc: devicetree, linux-media, Leon Luo, mchehab, sakari.ailus,
hverkuil-cisco, laurent.pinchart, linux-renesas-soc
On Mon, Aug 24, 2020 at 12:58:50PM +0200, Jacopo Mondi wrote:
> Convert the imx274 bindings document to json-schema and update
> the MAINTAINERS file accordingly.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> .../devicetree/bindings/media/i2c/imx274.txt | 38 -----------
> .../bindings/media/i2c/sony,imx274.yaml | 68 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 69 insertions(+), 39 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> deleted file mode 100644
> index 0727079d2410..000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> +++ /dev/null
> @@ -1,38 +0,0 @@
> -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
> -
> -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
> -an active array size of 3864H x 2202V. It is programmable through I2C
> -interface. The I2C address is fixed to 0x1a as per sensor data sheet.
> -Image data is sent through MIPI CSI-2, which is configured as 4 lanes
> -at 1440 Mbps.
> -
> -
> -Required Properties:
> -- compatible: value should be "sony,imx274" for imx274 sensor
> -- reg: I2C bus address of the device
> -
> -Optional Properties:
> -- reset-gpios: Sensor reset GPIO
> -- clocks: Reference to the input clock.
> -- clock-names: Should be "inck".
> -- VANA-supply: Sensor 2.8v analog supply.
> -- VDIG-supply: Sensor 1.8v digital core supply.
> -- VDDL-supply: Sensor digital IO 1.2v supply.
> -
> -The imx274 device node should contain one 'port' child node with
> -an 'endpoint' subnode. For further reading on port node refer to
> -Documentation/devicetree/bindings/media/video-interfaces.txt.
> -
> -Example:
> - sensor@1a {
> - compatible = "sony,imx274";
> - reg = <0x1a>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reset-gpios = <&gpio_sensor 0 0>;
> - port {
> - sensor_out: endpoint {
> - remote-endpoint = <&csiss_in>;
> - };
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> new file mode 100644
> index 000000000000..7ae47a614d2e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
> +
> +maintainers:
> + - Leon Luo <leonl@leopardimaging.com>
> +
> +description: -|
> + The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
> + active array size of 3864H x 2202V. It is programmable through I2C interface.
> + Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
> + Mbps.
> +
> +properties:
> + compatible:
> + const: sony,imx274
> +
> + reg:
> + const: 0x1a
> +
> + reset-gpios:
> + maxItems: 1
> +
> + port:
> + type: object
> + description: |
> + The device node must contain one 'port' child node for its digital output
> + video port, in accordance with the video interface bindings defined in
> + Documentation/devicetree/bindings/media/video-interfaces.txt.
> +
> + properties:
> + endpoint:
> + type: object
> + properties:
> + remote-endpoint:
> + description: A phandle to the bus receiver's endpoint node.
As discussed, drop 'endpoint'.
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - port
additionalProperties: false
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + imx274: camera-sensor@1a {
> + compatible = "sony,imx274";
> + reg = <0x1a>;
> + reset-gpios = <&gpio_sensor 0 0>;
> +
> + port {
> + sensor_out: endpoint {
> + remote-endpoint = <&csiss_in>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9503ea17aa28..dc7b1ea8e7b3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16125,7 +16125,7 @@ M: Leon Luo <leonl@leopardimaging.com>
> L: linux-media@vger.kernel.org
> S: Maintained
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/i2c/imx274.txt
> +F: Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> F: drivers/media/i2c/imx274.c
>
> SONY IMX290 SENSOR DRIVER
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: media: imx274: Convert to json-schema
2020-08-28 22:12 ` Rob Herring
@ 2020-08-29 10:04 ` Jacopo Mondi
0 siblings, 0 replies; 3+ messages in thread
From: Jacopo Mondi @ 2020-08-29 10:04 UTC (permalink / raw)
To: Rob Herring
Cc: Jacopo Mondi, devicetree, linux-media, Leon Luo, mchehab,
sakari.ailus, hverkuil-cisco, laurent.pinchart,
linux-renesas-soc
Hi Rob,
On Fri, Aug 28, 2020 at 04:12:25PM -0600, Rob Herring wrote:
> On Mon, Aug 24, 2020 at 12:58:50PM +0200, Jacopo Mondi wrote:
> > Convert the imx274 bindings document to json-schema and update
> > the MAINTAINERS file accordingly.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> > .../devicetree/bindings/media/i2c/imx274.txt | 38 -----------
> > .../bindings/media/i2c/sony,imx274.yaml | 68 +++++++++++++++++++
> > MAINTAINERS | 2 +-
> > 3 files changed, 69 insertions(+), 39 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > deleted file mode 100644
> > index 0727079d2410..000000000000
> > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > +++ /dev/null
> > @@ -1,38 +0,0 @@
> > -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
> > -
> > -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
> > -an active array size of 3864H x 2202V. It is programmable through I2C
> > -interface. The I2C address is fixed to 0x1a as per sensor data sheet.
> > -Image data is sent through MIPI CSI-2, which is configured as 4 lanes
> > -at 1440 Mbps.
> > -
> > -
> > -Required Properties:
> > -- compatible: value should be "sony,imx274" for imx274 sensor
> > -- reg: I2C bus address of the device
> > -
> > -Optional Properties:
> > -- reset-gpios: Sensor reset GPIO
> > -- clocks: Reference to the input clock.
> > -- clock-names: Should be "inck".
> > -- VANA-supply: Sensor 2.8v analog supply.
> > -- VDIG-supply: Sensor 1.8v digital core supply.
> > -- VDDL-supply: Sensor digital IO 1.2v supply.
> > -
> > -The imx274 device node should contain one 'port' child node with
> > -an 'endpoint' subnode. For further reading on port node refer to
> > -Documentation/devicetree/bindings/media/video-interfaces.txt.
> > -
> > -Example:
> > - sensor@1a {
> > - compatible = "sony,imx274";
> > - reg = <0x1a>;
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > - reset-gpios = <&gpio_sensor 0 0>;
> > - port {
> > - sensor_out: endpoint {
> > - remote-endpoint = <&csiss_in>;
> > - };
> > - };
> > - };
> > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > new file mode 100644
> > index 000000000000..7ae47a614d2e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > @@ -0,0 +1,68 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
> > +
> > +maintainers:
> > + - Leon Luo <leonl@leopardimaging.com>
> > +
> > +description: -|
> > + The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
> > + active array size of 3864H x 2202V. It is programmable through I2C interface.
> > + Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
> > + Mbps.
> > +
> > +properties:
> > + compatible:
> > + const: sony,imx274
> > +
> > + reg:
> > + const: 0x1a
> > +
> > + reset-gpios:
> > + maxItems: 1
> > +
> > + port:
> > + type: object
> > + description: |
> > + The device node must contain one 'port' child node for its digital output
> > + video port, in accordance with the video interface bindings defined in
> > + Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +
> > + properties:
> > + endpoint:
> > + type: object
> > + properties:
> > + remote-endpoint:
> > + description: A phandle to the bus receiver's endpoint node.
>
> As discussed, drop 'endpoint'.
>
Yes indeed. Discussion has been finalized after I sent this one out.
Same for the mt9v111 bindings you can skip review of.
I'll drop endpoint and defer it to a future of-graph.yaml
Thanks
j
> > +
> > + additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - port
>
> additionalProperties: false
>
> > +
> > +examples:
> > + - |
> > + i2c0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + imx274: camera-sensor@1a {
> > + compatible = "sony,imx274";
> > + reg = <0x1a>;
> > + reset-gpios = <&gpio_sensor 0 0>;
> > +
> > + port {
> > + sensor_out: endpoint {
> > + remote-endpoint = <&csiss_in>;
> > + };
> > + };
> > + };
> > + };
> > +
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 9503ea17aa28..dc7b1ea8e7b3 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16125,7 +16125,7 @@ M: Leon Luo <leonl@leopardimaging.com>
> > L: linux-media@vger.kernel.org
> > S: Maintained
> > T: git git://linuxtv.org/media_tree.git
> > -F: Documentation/devicetree/bindings/media/i2c/imx274.txt
> > +F: Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > F: drivers/media/i2c/imx274.c
> >
> > SONY IMX290 SENSOR DRIVER
> > --
> > 2.27.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-29 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 10:58 [PATCH v3] dt-bindings: media: imx274: Convert to json-schema Jacopo Mondi
2020-08-28 22:12 ` Rob Herring
2020-08-29 10:04 ` Jacopo Mondi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).