From: Luca Ceresoli <luca@lucaceresoli.net>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 26/31] adv748x: csi2: add internal routing configuration
Date: Thu, 14 Mar 2019 15:45:27 +0100 [thread overview]
Message-ID: <4f5b5763-be90-4040-7d55-986471168de1@lucaceresoli.net> (raw)
In-Reply-To: <20190305185150.20776-27-jacopo+renesas@jmondi.org>
Hi,
begging your pardon for the noob question below...
On 05/03/19 19:51, Jacopo Mondi wrote:
> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Add support to get and set the internal routing between the adv748x
> CSI-2 transmitters sink pad and its multiplexed source pad. This routing
> includes which stream of the multiplexed pad to use, allowing the user
> to select which CSI-2 virtual channel to use when transmitting the
> stream.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> drivers/media/i2c/adv748x/adv748x-csi2.c | 65 ++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c
> index d8f7cbee86e7..13454af72c6e 100644
> --- a/drivers/media/i2c/adv748x/adv748x-csi2.c
> +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c
> @@ -14,6 +14,8 @@
>
> #include "adv748x.h"
>
> +#define ADV748X_CSI2_ROUTES_MAX 4
> +
> struct adv748x_csi2_format {
> unsigned int code;
> unsigned int datatype;
> @@ -253,10 +255,73 @@ static int adv748x_csi2_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
> return 0;
> }
>
> +static int adv748x_csi2_get_routing(struct v4l2_subdev *sd,
> + struct v4l2_subdev_krouting *routing)
> +{
> + struct adv748x_csi2 *tx = adv748x_sd_to_csi2(sd);
> + struct v4l2_subdev_route *r = routing->routes;
> + unsigned int vc;
> +
> + if (routing->num_routes < ADV748X_CSI2_ROUTES_MAX) {
> + routing->num_routes = ADV748X_CSI2_ROUTES_MAX;
> + return -ENOSPC;
> + }
> +
> + routing->num_routes = ADV748X_CSI2_ROUTES_MAX;
> +
> + for (vc = 0; vc < ADV748X_CSI2_ROUTES_MAX; vc++) {
> + r->sink_pad = ADV748X_CSI2_SINK;
> + r->sink_stream = 0;
> + r->source_pad = ADV748X_CSI2_SOURCE;
> + r->source_stream = vc;
> + r->flags = vc == tx->vc ? V4L2_SUBDEV_ROUTE_FL_ACTIVE : 0;
> + r++;Begging your pardon for the noob question...
> + }
> +
> + return 0;
> +}
> +
> +static int adv748x_csi2_set_routing(struct v4l2_subdev *sd,
> + struct v4l2_subdev_krouting *routing)
> +{
> + struct adv748x_csi2 *tx = adv748x_sd_to_csi2(sd);
> + struct v4l2_subdev_route *r = routing->routes;
> + unsigned int i;
> + int vc = -1;
> +
> + if (routing->num_routes > ADV748X_CSI2_ROUTES_MAX)
> + return -ENOSPC;
> +
> + for (i = 0; i < routing->num_routes; i++) {
> + if (r->sink_pad != ADV748X_CSI2_SINK ||
> + r->sink_stream != 0 ||
> + r->source_pad != ADV748X_CSI2_SOURCE ||
> + r->source_stream >= ADV748X_CSI2_ROUTES_MAX)
> + return -EINVAL;
> +
> + if (r->flags & V4L2_SUBDEV_ROUTE_FL_ACTIVE) {
> + if (vc != -1)
> + return -EMLINK;
> +
> + vc = r->source_stream;
> + }
> + r++;
> + }
> +
> + if (vc != -1)
> + tx->vc = vc;
> +
> + adv748x_csi2_set_virtual_channel(tx, tx->vc);
> +
> + return 0;
> +}
Not specific to this patch but rather to the set_routing idea as a
whole: can the set_routing ioctl be called while the stream is running?
If it cannot, I find it a limiting factor for nowadays use cases. I also
didn't find where the ioctl is rejected.
If it can, then shouldn't this function call s_stream(stop) through the
sink pad whose route becomes disabled, and a s_stream(start) through the
one that gets enabled?
Thanks,
--
Luca
next prev parent reply other threads:[~2019-03-14 15:15 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 18:51 [PATCH v3 00/31] v4l: add support for multiplexed streams Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 01/31] media: entity: Use pad as a starting point for graph walk Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 02/31] media: entity: Use pads instead of entities in the media graph walk stack Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 03/31] media: entity: Walk the graph based on pads Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 04/31] v4l: mc: Start walk from a specific pad in use count calculation Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 05/31] media: entity: Add iterator helper for entity pads Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 06/31] media: entity: Move the pipeline from entity to pads Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 07/31] media: entity: Use pad as the starting point for a pipeline Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 08/31] media: entity: Add has_route entity operation Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 09/31] media: entity: Add media_has_route() function Jacopo Mondi
2019-03-14 14:45 ` Luca Ceresoli
2019-03-15 9:22 ` Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 10/31] media: entity: Use routing information during graph traversal Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 11/31] media: entity: Skip link validation for pads to which there is no route to Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 12/31] media: entity: Add an iterator helper for connected pads Jacopo Mondi
2019-03-07 10:09 ` Sakari Ailus
2019-03-07 10:27 ` Ian Arkver
2019-03-07 12:38 ` Sakari Ailus
2019-03-07 20:18 ` Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 13/31] media: entity: Add only connected pads to the pipeline Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 14/31] media: entity: Add debug information in graph walk route check Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 15/31] v4l: Add bus type to frame descriptors Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 16/31] v4l: Add CSI-2 bus configuration " Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 17/31] v4l: Add stream to frame descriptor Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 18/31] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 19/31] media: Documentation: Add GS_ROUTING documentation Jacopo Mondi
2019-03-07 15:19 ` Sakari Ailus
2019-03-08 13:31 ` Jacopo Mondi
2019-03-08 14:14 ` Sakari Ailus
2019-03-14 14:44 ` Luca Ceresoli
2019-03-14 14:43 ` Luca Ceresoli
2020-02-13 13:36 ` Hans Verkuil
2019-03-05 18:51 ` [PATCH v3 20/31] v4l: subdev: Take routing information into account in link validation Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 21/31] v4l: subdev: Improve link format validation debug messages Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 22/31] v4l: mc: Add an S_ROUTING helper function for power state changes Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 23/31] adv748x: csi2: add translation from pixelcode to CSI-2 datatype Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 24/31] adv748x: csi2: only allow formats on sink pads Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 25/31] adv748x: csi2: describe the multiplexed stream Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 26/31] adv748x: csi2: add internal routing configuration Jacopo Mondi
2019-03-14 14:45 ` Luca Ceresoli [this message]
2019-03-15 9:45 ` Jacopo Mondi
2019-03-15 10:06 ` Sakari Ailus
2019-03-16 10:23 ` Luca Ceresoli
2019-03-20 17:14 ` Jacopo Mondi
2019-03-22 16:52 ` Luca Ceresoli
2019-03-28 15:08 ` Jacopo Mondi
2019-03-28 15:17 ` Luca Ceresoli
2019-03-05 18:51 ` [PATCH v3 27/31] adv748x: afe: add routing support Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 28/31] adv748x: afe: Implement has_route() Jacopo Mondi
2019-03-07 12:49 ` Sakari Ailus
2019-03-14 14:45 ` Luca Ceresoli
2019-03-05 18:51 ` [PATCH v3 29/31] rcar-csi2: use frame description information to configure CSI-2 bus Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 30/31] rcar-csi2: expose the subdevice internal routing Jacopo Mondi
2019-03-05 18:51 ` [PATCH v3 31/31] media: rcar-csi2: Implement has_route() Jacopo Mondi
2019-03-07 12:56 ` Sakari Ailus
2019-03-07 22:28 ` Jacopo Mondi
2019-03-07 9:47 ` [PATCH v3 00/31] v4l: add support for multiplexed streams Sakari Ailus
2019-03-08 13:19 ` Jacopo Mondi
2019-03-08 14:12 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f5b5763-be90-4040-7d55-986471168de1@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).