* [PATCH] v4l2-compliance: zero mbus_code
@ 2020-04-23 10:48 Hans Verkuil
2020-04-24 13:32 ` Laurent Pinchart
2020-04-28 12:09 ` Niklas Söderlund
0 siblings, 2 replies; 3+ messages in thread
From: Hans Verkuil @ 2020-04-23 10:48 UTC (permalink / raw)
To: Linux Media Mailing List, Niklas Söderlund, Helen Koike,
Sakari Ailus, Laurent Pinchart
Cc: Linux-Renesas
The new fmtdesc.mbus_code should be zeroed by applications.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp
index 824769b3..269a5fd9 100644
--- a/utils/v4l2-compliance/v4l2-test-formats.cpp
+++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
@@ -235,6 +235,7 @@ static int testEnumFormatsType(struct node *node, unsigned type)
memset(&fmtdesc, 0xff, sizeof(fmtdesc));
fmtdesc.type = type;
fmtdesc.index = f;
+ fmtdesc.mbus_code = 0;
ret = doioctl(node, VIDIOC_ENUM_FMT, &fmtdesc);
if (ret == ENOTTY)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l2-compliance: zero mbus_code
2020-04-23 10:48 [PATCH] v4l2-compliance: zero mbus_code Hans Verkuil
@ 2020-04-24 13:32 ` Laurent Pinchart
2020-04-28 12:09 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2020-04-24 13:32 UTC (permalink / raw)
To: Hans Verkuil
Cc: Linux Media Mailing List, Niklas Söderlund, Helen Koike,
Sakari Ailus, Linux-Renesas
Hi Hans,
Thank you for the patch.
On Thu, Apr 23, 2020 at 12:48:20PM +0200, Hans Verkuil wrote:
> The new fmtdesc.mbus_code should be zeroed by applications.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp
> index 824769b3..269a5fd9 100644
> --- a/utils/v4l2-compliance/v4l2-test-formats.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
> @@ -235,6 +235,7 @@ static int testEnumFormatsType(struct node *node, unsigned type)
> memset(&fmtdesc, 0xff, sizeof(fmtdesc));
> fmtdesc.type = type;
> fmtdesc.index = f;
> + fmtdesc.mbus_code = 0;
>
> ret = doioctl(node, VIDIOC_ENUM_FMT, &fmtdesc);
> if (ret == ENOTTY)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l2-compliance: zero mbus_code
2020-04-23 10:48 [PATCH] v4l2-compliance: zero mbus_code Hans Verkuil
2020-04-24 13:32 ` Laurent Pinchart
@ 2020-04-28 12:09 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2020-04-28 12:09 UTC (permalink / raw)
To: Hans Verkuil
Cc: Linux Media Mailing List, Helen Koike, Sakari Ailus,
Laurent Pinchart, Linux-Renesas
Hi Hans,
Thanks for your work.
On 2020-04-23 12:48:20 +0200, Hans Verkuil wrote:
> The new fmtdesc.mbus_code should be zeroed by applications.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp
> index 824769b3..269a5fd9 100644
> --- a/utils/v4l2-compliance/v4l2-test-formats.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
> @@ -235,6 +235,7 @@ static int testEnumFormatsType(struct node *node, unsigned type)
> memset(&fmtdesc, 0xff, sizeof(fmtdesc));
> fmtdesc.type = type;
> fmtdesc.index = f;
> + fmtdesc.mbus_code = 0;
>
> ret = doioctl(node, VIDIOC_ENUM_FMT, &fmtdesc);
> if (ret == ENOTTY)
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-28 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 10:48 [PATCH] v4l2-compliance: zero mbus_code Hans Verkuil
2020-04-24 13:32 ` Laurent Pinchart
2020-04-28 12:09 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).