[PATCH] mmc: renesas_sdhi: simplify summary output

[PATCH] mmc: renesas_sdhi: simplify summary output

[Wolfram Sang]

No need to call platform_get_resource twice when we still have the
pointer from before. Also, use '%pa' for a resource_size_t pointer.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mmc/host/renesas_sdhi_core.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index c002e9fb67fb..de7f4fc9bc21 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -933,10 +933,8 @@ int renesas_sdhi_probe(struct platform_device *pdev,
 			goto eirq;
 	}
 
-	dev_info(&pdev->dev, "%s base at 0x%08lx max clock rate %u MHz\n",
-		 mmc_hostname(host->mmc), (unsigned long)
-		 (platform_get_resource(pdev, IORESOURCE_MEM, 0)->start),
-		 host->mmc->f_max / 1000000);
+	dev_info(&pdev->dev, "%s base at %pa, max clock rate %u MHz\n",
+		 mmc_hostname(host->mmc), &res->start, host->mmc->f_max / 1000000);
 
 	return ret;
 
-- 
2.20.1

Re: [PATCH] mmc: renesas_sdhi: simplify summary output

[Niklas Söderlund]

Hi Wolfram,

Thanks for your work.

On 2020-04-08 16:22:52 +0200, Wolfram Sang wrote:
> No need to call platform_get_resource twice when we still have the
> pointer from before. Also, use '%pa' for a resource_size_t pointer.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  drivers/mmc/host/renesas_sdhi_core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index c002e9fb67fb..de7f4fc9bc21 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -933,10 +933,8 @@ int renesas_sdhi_probe(struct platform_device *pdev,
>  			goto eirq;
>  	}
>  
> -	dev_info(&pdev->dev, "%s base at 0x%08lx max clock rate %u MHz\n",
> -		 mmc_hostname(host->mmc), (unsigned long)
> -		 (platform_get_resource(pdev, IORESOURCE_MEM, 0)->start),
> -		 host->mmc->f_max / 1000000);
> +	dev_info(&pdev->dev, "%s base at %pa, max clock rate %u MHz\n",
> +		 mmc_hostname(host->mmc), &res->start, host->mmc->f_max / 1000000);
>  
>  	return ret;
>  
> -- 
> 2.20.1
> 

-- 
Regards,
Niklas Söderlund

Re: [PATCH] mmc: renesas_sdhi: simplify summary output

[Ulf Hansson]

On Wed, 8 Apr 2020 at 16:25, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> No need to call platform_get_resource twice when we still have the
> pointer from before. Also, use '%pa' for a resource_size_t pointer.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/renesas_sdhi_core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index c002e9fb67fb..de7f4fc9bc21 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -933,10 +933,8 @@ int renesas_sdhi_probe(struct platform_device *pdev,
>                         goto eirq;
>         }
>
> -       dev_info(&pdev->dev, "%s base at 0x%08lx max clock rate %u MHz\n",
> -                mmc_hostname(host->mmc), (unsigned long)
> -                (platform_get_resource(pdev, IORESOURCE_MEM, 0)->start),
> -                host->mmc->f_max / 1000000);
> +       dev_info(&pdev->dev, "%s base at %pa, max clock rate %u MHz\n",
> +                mmc_hostname(host->mmc), &res->start, host->mmc->f_max / 1000000);
>
>         return ret;
>
> --
> 2.20.1
>

Re: [PATCH] mmc: renesas_sdhi: simplify summary output

[Geert Uytterhoeven]

On Wed, Apr 8, 2020 at 5:17 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> No need to call platform_get_resource twice when we still have the
> pointer from before. Also, use '%pa' for a resource_size_t pointer.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds