From: Marek Vasut <marek.vasut@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: r8a779x: Configure PMIC IRQ pinmux
Date: Wed, 15 May 2019 10:25:10 +0200 [thread overview]
Message-ID: <b0dd348d-2a14-96d4-da19-3984dfe1bbeb@gmail.com> (raw)
In-Reply-To: <CAMuHMdXrK7CMhBjFXAYX4wUPK=4Q2LpBCu+65-t5Y7-VjEBsog@mail.gmail.com>
On 5/3/19 8:13 PM, Geert Uytterhoeven wrote:
> Hi Marek,
Hi,
> On Fri, May 3, 2019 at 5:18 PM Marek Vasut <marek.vasut@gmail.com> wrote:
>> On 5/3/19 2:36 PM, Geert Uytterhoeven wrote:
>>>> &rwdt {
>>>> @@ -309,6 +314,8 @@
>>>> };
>>>>
>>>> &iic3 {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pmic_irq_pins>;
>>>
>>> Given Blanche has a single device connected to irq2, I think it makes
>>> sense to move the pinctrl properties to the pmic node below.
>>
>> It makes blanche somehow inconsistent with the other boards, but if you
>> insist ... ?
>
> Typically the pinctrl properties are part of the device node that uses them.
> For the other boards, that's not possible, as they are shared by all PMIC
> nodes. Hence the other boards are the exceptions, actually ;-)
>
> Note that for multi-PMIC boards, adding the pinctrl properties to a single
> PMIC node won't work, as that would break:
> 1. The case where the driver for that PMIC is not compiled in,
> 2. The R-Car Gen2 regulator quirk.
Well it wouldn't work because it's shared by two PMICs and thus two
driver instances in the first place.
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2019-05-15 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 14:06 [PATCH] ARM: dts: r8a779x: Configure PMIC IRQ pinmux marek.vasut
2019-05-03 12:36 ` Geert Uytterhoeven
2019-05-03 15:18 ` Marek Vasut
2019-05-03 18:13 ` Geert Uytterhoeven
2019-05-15 8:25 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0dd348d-2a14-96d4-da19-3984dfe1bbeb@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).