From: Marek Vasut <marek.vasut@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: r8a779x: Configure PMIC IRQ pinmux
Date: Fri, 3 May 2019 17:18:17 +0200 [thread overview]
Message-ID: <fa79e656-d71a-6f3d-21a5-8acac72e20f0@gmail.com> (raw)
In-Reply-To: <CAMuHMdVGAq1XgSohBjc8i4c_o-N-yWGedS_LLS_Apr4Bx10xGQ@mail.gmail.com>
On 5/3/19 2:36 PM, Geert Uytterhoeven wrote:
Hi,
[...]
>> &rwdt {
>> @@ -309,6 +314,8 @@
>> };
>>
>> &iic3 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pmic_irq_pins>;
>
> Given Blanche has a single device connected to irq2, I think it makes
> sense to move the pinctrl properties to the pmic node below.
It makes blanche somehow inconsistent with the other boards, but if you
insist ... ?
> With that fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
> Geert
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-05-03 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 14:06 [PATCH] ARM: dts: r8a779x: Configure PMIC IRQ pinmux marek.vasut
2019-05-03 12:36 ` Geert Uytterhoeven
2019-05-03 15:18 ` Marek Vasut [this message]
2019-05-03 18:13 ` Geert Uytterhoeven
2019-05-15 8:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa79e656-d71a-6f3d-21a5-8acac72e20f0@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).