From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: Conor.Dooley@microchip.com
Cc: alexandre.ghiti@canonical.com, heiko@sntech.de,
palmer@dabbelt.com, mick@ics.forth.gr, guoren@kernel.org,
kexec@lists.infradead.org, bhe@redhat.com,
linux-doc@vger.kernel.org, vgoyal@redhat.com,
linux-riscv@lists.infradead.org, dyoung@redhat.com,
linux-kernel@vger.kernel.org, crash-utility@redhat.com,
huanyi.xj@alibaba-inc.com, heinrich.schuchardt@canonical.com,
anup@brainfault.org, corbet@lwn.net, k-hagio-ab@nec.com,
hschauhan@nulltrace.org, paul.walmsley@sifive.com,
aou@eecs.berkeley.edu
Subject: Re: [RESEND PATCH V2 0/5] Fixups to work with crash tool
Date: Tue, 26 Jul 2022 17:42:39 +0800 [thread overview]
Message-ID: <00776b91-6bff-e4b8-f000-5399924cd145@linux.alibaba.com> (raw)
In-Reply-To: <6320e6dd-ebd9-3575-a85f-c3a2f92e9f54@linux.alibaba.com>
在 2022/7/26 下午5:28, Xianting Tian 写道:
>
> 在 2022/7/26 下午4:16, Xianting Tian 写道:
>>
>> 在 2022/7/26 下午4:01, Conor.Dooley@microchip.com 写道:
>>> On 26/07/2022 08:54, tianxianting wrote:
>>>> 在 2022/7/26 上午1:13, Conor.Dooley@microchip.com 写道:
>>>>> That said, this does not apply to riscv/for-next:
>>>>> b4 shazam 20220725014539.1037627-1-xianting.tian@linux.alibaba.com
>>>>> Grabbing thread from
>>>>> lore.kernel.org/all/20220725014539.1037627-1-xianting.tian%40linux.alibaba.com/t.mbox.gz
>>>>> Checking for newer revisions on https://lore.kernel.org/all/
>>>>> Analyzing 6 messages in the thread
>>>>> Checking attestation on all messages, may take a moment...
>>>>> ---
>>>>> [PATCH v2 1/5] RISC-V: use __smp_processor_id() instead of
>>>>> smp_processor_id()
>>>>> [PATCH v2 2/5] RISC-V: Add arch_crash_save_vmcoreinfo support
>>>>> [PATCH v2 3/5] riscv: Add modules to virtual kernel memory
>>>>> layout dump
>>>>> [PATCH v2 4/5] RISC-V: Fixup getting correct current pc
>>>>> [PATCH v2 5/5] riscv: crash_core: Export kernel vm layout,
>>>>> phys_ram_base
>>>>> ---
>>>>> Total patches: 5
>>>>> ---
>>>>> Applying: RISC-V: use __smp_processor_id() instead of
>>>>> smp_processor_id()
>>>>> Applying: RISC-V: Add arch_crash_save_vmcoreinfo support
>>>>> Patch failed at 0002 RISC-V: Add arch_crash_save_vmcoreinfo support
>>>> patch 2 apply is OK for me, I don't know why you failed :(
>>>> Do you have more detals for this?
>>>>
>>> What did you apply it to? It does not apply for me to riscv/for-next:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=for-next
>>>
>>
>> This 5 patches are based on the master branch of below git:
>>
>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git
>>
>>
>> "git am 0002-RISC-V-Add-arch_crash_save_vmcoreinfo-support.patch" to
>> this git is ok for me.
>>
>> All is correct?
>
> I figured out the reason, there is one difference in
> arch/riscv/kernel/Makefile between riscv/for-next and torvalds/linux.
>
> For riscv/for-next, in line 81 of arch/riscv/kernel/Makefile, it is:
>
> obj-$(CONFIG_KEXEC) += kexec_relocate.o crash_save_regs.o
> machine_kexec.o
>
> But for torvalds/linux, in line 81 of arch/riscv/kernel/Makefile, it is:
>
> obj-$(CONFIG_KEXEC_CORE) += kexec_relocate.o
> crash_save_regs.o machine_kexec.o
>
> torvalds/linux is newer than riscv/for-next, commit 3a66a08759
> ("RISC-V: kexec: Fix build error without CONFIG_KEXEC") added
> "CONFIG_KEXEC_CORE" for torvalds/linux, But riscv/for-next
>
> doesn't contain the commit.
Hi Dooley
I think riscv git needs to be updated from linus git, and then I think
V4 can be applied normally.
V4: https://lkml.org/lkml/2022/7/26/317
>
>
>>
>>>
>>> Thanks,
>>> Conor.
>>>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-26 9:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 1:45 [RESEND PATCH V2 0/5] Fixups to work with crash tool Xianting Tian
2022-07-25 1:45 ` [RESEND PATCH V2 1/5] RISC-V: use __smp_processor_id() instead of smp_processor_id() Xianting Tian
2022-07-25 1:45 ` [RESEND PATCH V2 2/5] RISC-V: Add arch_crash_save_vmcoreinfo support Xianting Tian
2022-07-25 1:45 ` [RESEND PATCH V2 3/5] riscv: Add modules to virtual kernel memory layout dump Xianting Tian
2022-07-25 1:45 ` [RESEND PATCH V2 4/5] RISC-V: Fixup getting correct current pc Xianting Tian
2022-07-25 1:45 ` [RESEND PATCH V2 5/5] riscv: crash_core: Export kernel vm layout, phys_ram_base Xianting Tian
2022-07-25 17:13 ` [RESEND PATCH V2 0/5] Fixups to work with crash tool Conor.Dooley
2022-07-26 7:54 ` tianxianting
2022-07-26 8:01 ` Conor.Dooley
2022-07-26 8:16 ` Xianting Tian
2022-07-26 9:28 ` Xianting Tian
2022-07-26 9:42 ` Xianting Tian [this message]
2022-07-26 9:42 ` Conor.Dooley
2022-07-26 9:47 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00776b91-6bff-e4b8-f000-5399924cd145@linux.alibaba.com \
--to=xianting.tian@linux.alibaba.com \
--cc=Conor.Dooley@microchip.com \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=crash-utility@redhat.com \
--cc=dyoung@redhat.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=heinrich.schuchardt@canonical.com \
--cc=hschauhan@nulltrace.org \
--cc=huanyi.xj@alibaba-inc.com \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).