linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <xianting.tian@linux.alibaba.com>, <paul.walmsley@sifive.com>,
	<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	<anup@brainfault.org>, <heiko@sntech.de>, <guoren@kernel.org>,
	<mick@ics.forth.gr>, <alexandre.ghiti@canonical.com>,
	<bhe@redhat.com>, <vgoyal@redhat.com>, <dyoung@redhat.com>,
	<corbet@lwn.net>
Cc: <kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<crash-utility@redhat.com>, <huanyi.xj@alibaba-inc.com>,
	<heinrich.schuchardt@canonical.com>, <k-hagio-ab@nec.com>,
	<hschauhan@nulltrace.org>
Subject: Re: [RESEND PATCH V2 0/5] Fixups to work with crash tool
Date: Mon, 25 Jul 2022 17:13:36 +0000	[thread overview]
Message-ID: <51c97da7-422f-1b5b-03d3-dc36c9132c2a@microchip.com> (raw)
In-Reply-To: <20220725014539.1037627-1-xianting.tian@linux.alibaba.com>

On 25/07/2022 02:45, Xianting Tian wrote:
> [RESEND PATCH V2 0/5] Fixups to work with crash tool

FWIW, this is not a "resend" - there's at least a commit message
difference here so this should have been v3. Also your cover letter
was not the one generated for the patches you actually sent since
it still mentions "riscv64" in the subject line for patch 5.

That said, this does not apply to riscv/for-next:
b4 shazam 20220725014539.1037627-1-xianting.tian@linux.alibaba.com
Grabbing thread from lore.kernel.org/all/20220725014539.1037627-1-xianting.tian%40linux.alibaba.com/t.mbox.gz
Checking for newer revisions on https://lore.kernel.org/all/
Analyzing 6 messages in the thread
Checking attestation on all messages, may take a moment...
---
  [PATCH v2 1/5] RISC-V: use __smp_processor_id() instead of smp_processor_id()
  [PATCH v2 2/5] RISC-V: Add arch_crash_save_vmcoreinfo support
  [PATCH v2 3/5] riscv: Add modules to virtual kernel memory layout dump
  [PATCH v2 4/5] RISC-V: Fixup getting correct current pc
  [PATCH v2 5/5] riscv: crash_core: Export kernel vm layout, phys_ram_base
---
Total patches: 5
---
Applying: RISC-V: use __smp_processor_id() instead of smp_processor_id()
Applying: RISC-V: Add arch_crash_save_vmcoreinfo support
Patch failed at 0002 RISC-V: Add arch_crash_save_vmcoreinfo support

When you fix that, could you also pick either "riscv" or "RISC-V" as a
prefix the series?

Thanks,
Conor.

> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> I ever sent the patch 1 in the link:
> https://patchwork.kernel.org/project/linux-riscv/patch/20220708073150.352830-3-xianting.tian@linux.alibaba.com/
> And patch 2,3 in the link:
> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-2-xianting.tian@linux.alibaba.com/
> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-3-xianting.tian@linux.alibaba.com/
> 
> This patch series just put these patches together, and with two new patch 4, 5.
> these five patches are the fixups for machine_kexec, kernel mode PC for vmcore
> and improvements for vmcoreinfo and memory layout dump.
> 
> The main changes in the five patchs as below,
> Patch 1: use __smp_processor_id() instead of smp_processor_id() to cleanup
>          the console prints.
> Patch 2: Add VM layout, va bits, ram base to vmcoreinfo, which can simplify
>          the development of crash tool as ARM64 already did
>          (arch/arm64/kernel/crash_core.c).
> Patch 3: Add modules to virtual kernel memory layout dump.
> Patch 4: Fixup to get correct kernel mode PC for vmcore.
> Patch 5: Updates vmcoreinfo.rst.
> 
> With these 5 patches(patch 2 is must), crash tool can work well to analyze
> a vmcore. The patches for crash tool for RISCV64 is in the link:
> https://lore.kernel.org/linux-riscv/20220718025346.411758-1-xianting.tian@linux.alibaba.com/
> 
> Changes v1 -> v2:
>  1, remove the patch "Add a fast call path of crash_kexec()" from this series
>  of patches, as it already applied to riscv git.
>  https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98
>  2, add 'Reviewed-by' based on the comments of v1.
> 
> Xianting Tian (5):
>   RISC-V: use __smp_processor_id() instead of smp_processor_id()
>   RISC-V: Add arch_crash_save_vmcoreinfo support
>   riscv: Add modules to virtual kernel memory layout dump
>   RISC-V: Fixup getting correct current pc
>   riscv64: crash_core: Export kernel vm layout, phys_ram_base
> 
>  .../admin-guide/kdump/vmcoreinfo.rst          | 31 +++++++++++++++++++
>  arch/riscv/kernel/Makefile                    |  1 +
>  arch/riscv/kernel/crash_core.c                | 29 +++++++++++++++++
>  arch/riscv/kernel/crash_save_regs.S           |  2 +-
>  arch/riscv/kernel/machine_kexec.c             |  2 +-
>  arch/riscv/mm/init.c                          |  4 +++
>  6 files changed, 67 insertions(+), 2 deletions(-)
>  create mode 100644 arch/riscv/kernel/crash_core.c
> 
> --
> 2.17.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2022-07-25 17:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  1:45 [RESEND PATCH V2 0/5] Fixups to work with crash tool Xianting Tian
2022-07-25  1:45 ` [RESEND PATCH V2 1/5] RISC-V: use __smp_processor_id() instead of smp_processor_id() Xianting Tian
2022-07-25  1:45 ` [RESEND PATCH V2 2/5] RISC-V: Add arch_crash_save_vmcoreinfo support Xianting Tian
2022-07-25  1:45 ` [RESEND PATCH V2 3/5] riscv: Add modules to virtual kernel memory layout dump Xianting Tian
2022-07-25  1:45 ` [RESEND PATCH V2 4/5] RISC-V: Fixup getting correct current pc Xianting Tian
2022-07-25  1:45 ` [RESEND PATCH V2 5/5] riscv: crash_core: Export kernel vm layout, phys_ram_base Xianting Tian
2022-07-25 17:13 ` Conor.Dooley [this message]
2022-07-26  7:54   ` [RESEND PATCH V2 0/5] Fixups to work with crash tool tianxianting
2022-07-26  8:01     ` Conor.Dooley
2022-07-26  8:16       ` Xianting Tian
2022-07-26  9:28         ` Xianting Tian
2022-07-26  9:42           ` Xianting Tian
2022-07-26  9:42           ` Conor.Dooley
2022-07-26  9:47             ` Xianting Tian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51c97da7-422f-1b5b-03d3-dc36c9132c2a@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=alexandre.ghiti@canonical.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=bhe@redhat.com \
    --cc=corbet@lwn.net \
    --cc=crash-utility@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=guoren@kernel.org \
    --cc=heiko@sntech.de \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=hschauhan@nulltrace.org \
    --cc=huanyi.xj@alibaba-inc.com \
    --cc=k-hagio-ab@nec.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=vgoyal@redhat.com \
    --cc=xianting.tian@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).