linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: me@packi.ch
Cc: me@packi.ch, aou@eecs.berkeley.edu, anup@brainfault.org,
	linux-kernel@vger.kernel.org, atish.patra@wdc.com,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: recognize S/U mode bits in print_isa
Date: Fri, 09 Nov 2018 13:07:03 -0800 (PST)	[thread overview]
Message-ID: <mhng-cff31d5f-053e-4e62-997c-232c8bdd5fd3@palmer-si-x1c4> (raw)
Message-ID: <20181109210703.FmluiiOiUC23mNTh_NIRn8goAbpMPAEoZrEVRwBpZK4@z> (raw)
In-Reply-To: <20181109193349.28179-1-me@packi.ch>

On Fri, 09 Nov 2018 11:33:47 PST (-0800), me@packi.ch wrote:
> Removes the warning about an unsupported ISA when reading /proc/cpuinfo
> on QEMU.
>
> Signed-off-by: Patrick Stählin <me@packi.ch>
> ---
>  arch/riscv/kernel/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c
> index 3a5a2ee31547..4029c7e6872b 100644
> --- a/arch/riscv/kernel/cpu.c
> +++ b/arch/riscv/kernel/cpu.c
> @@ -64,7 +64,7 @@ int riscv_of_processor_hartid(struct device_node *node)
>
>  static void print_isa(struct seq_file *f, const char *orig_isa)
>  {
> -	static const char *ext = "mafdc";
> +	static const char *ext = "mafdcsu";
>  	const char *isa = orig_isa;
>  	const char *e;

This is a bit pedantic, but the "S" extension should really be hidden from 
userspace.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2018-11-09 21:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 19:33 [PATCH] RISC-V: recognize S/U mode bits in print_isa Patrick Stählin
2018-11-09 19:33 ` Patrick Stählin
2018-11-09 21:07 ` Palmer Dabbelt [this message]
2018-11-09 21:07   ` Palmer Dabbelt
2018-11-09 21:42   ` [PATCH v2] " Patrick Stählin
2018-11-09 21:42     ` Patrick Stählin
2018-11-16 16:52     ` Palmer Dabbelt
2018-11-16 16:52       ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-cff31d5f-053e-4e62-997c-232c8bdd5fd3@palmer-si-x1c4 \
    --to=palmer@sifive.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=me@packi.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).