From: Tobias Klauser <tklauser@distanz.ch>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: "Albert Ou" <aou@eecs.berkeley.edu>,
"Björn Töpel" <bjorn.topel@gmail.com>,
syzkaller <syzkaller@googlegroups.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] riscv: enable kcov
Date: Fri, 26 Jun 2020 14:02:35 +0200 [thread overview]
Message-ID: <20200626120231.isx3fyhhpuuhwwco@distanz.ch> (raw)
In-Reply-To: <CACT4Y+azxRtnEQO9tH8nqM_o8VJaTRAiQmQAYhTsrWmVWWhLGw@mail.gmail.com>
On 2020-06-25 at 20:45:55 +0200, Dmitry Vyukov <dvyukov@google.com> wrote:
> On Thu, Jun 25, 2020 at 8:39 PM Tobias Klauser <tklauser@distanz.ch> wrote:
> >
> > Add ARCH_HAS_KCOV and HAVE_GCC_PLUGINS to the riscv Kconfig.
> > Also disable instrumentation of vdso.
> >
> > Cc: Björn Töpel <bjorn.topel@gmail.com>
> > Cc: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>
>
> If it boots:
>
> Acked-by: Dmitry Vyukov <dvyukov@google.com>
Yeah turns out I boot-tested this with a kernel which didn't have
CONFIG_KCOV enabled :-/ Will send a v2 patch.
> FWIW for x86 we needed to do much more of this:
>
> $ find arch/x86/ -name Makefile -exec grep KCOV_INSTRUMENT {} \; -print
> KCOV_INSTRUMENT := n
> arch/x86/kernel/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/kernel/apic/Makefile
> KCOV_INSTRUMENT_common.o := n
> KCOV_INSTRUMENT_perf_event.o := n
> arch/x86/kernel/cpu/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/realmode/rm/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/boot/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/boot/compressed/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/entry/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/entry/vdso/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/um/vdso/Makefile
> KCOV_INSTRUMENT_delay.o := n
> KCOV_INSTRUMENT_cmdline.o := n
> arch/x86/lib/Makefile
> KCOV_INSTRUMENT_tlb.o := n
> KCOV_INSTRUMENT_mem_encrypt.o := n
> KCOV_INSTRUMENT_mem_encrypt_identity.o := n
> arch/x86/mm/Makefile
> KCOV_INSTRUMENT := n
> arch/x86/purgatory/Makefile
Thanks, that's very helpful.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-06-26 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 18:39 [PATCH] riscv: enable kcov Tobias Klauser
2020-06-25 18:45 ` Dmitry Vyukov
2020-06-26 12:02 ` Tobias Klauser [this message]
2020-06-26 12:40 ` [PATCH v2] riscv: Allow building with kcov coverage Tobias Klauser
2020-06-26 14:28 ` Dmitry Vyukov
2020-07-11 4:27 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626120231.isx3fyhhpuuhwwco@distanz.ch \
--to=tklauser@distanz.ch \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn.topel@gmail.com \
--cc=dvyukov@google.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).