From: Palmer Dabbelt <palmer@dabbelt.com>
To: tklauser@distanz.ch
Cc: aou@eecs.berkeley.edu, Bjorn Topel <bjorn.topel@gmail.com>,
linux-kernel@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, dvyukov@google.com
Subject: Re: [PATCH v2] riscv: Allow building with kcov coverage
Date: Fri, 10 Jul 2020 21:27:30 -0700 (PDT) [thread overview]
Message-ID: <mhng-5606ac04-c52e-4211-bd30-fce86df7f0fd@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <20200626124056.29708-1-tklauser@distanz.ch>
On Fri, 26 Jun 2020 05:40:56 PDT (-0700), tklauser@distanz.ch wrote:
> Add ARCH_HAS_KCOV and HAVE_GCC_PLUGINS to the riscv Kconfig.
> Also disable instrumentation of some early boot code and vdso.
>
> Boot-tested on QEMU's riscv64 virt machine.
Thanks. This is on for-next (with the ack). I'm boot testing a config with
CONFIG_KCOV=y
CONFIG_KCOV_ENABLE_COMPARISONS=y
but LMK if there's something more interesting to test. I don't see anything
coverage-related in the boot log...
> Cc: Björn Töpel <bjorn.topel@gmail.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> arch/riscv/Kconfig | 2 ++
> arch/riscv/boot/Makefile | 2 ++
> arch/riscv/kernel/vdso/Makefile | 1 +
> arch/riscv/mm/Makefile | 2 ++
> 4 files changed, 7 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 089293e4ad46..a7d7f8184f15 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -19,6 +19,7 @@ config RISCV
> select ARCH_HAS_DEBUG_WX
> select ARCH_HAS_GCOV_PROFILE_ALL
> select ARCH_HAS_GIGANTIC_PAGE
> + select ARCH_HAS_KCOV
> select ARCH_HAS_MMIOWB
> select ARCH_HAS_PTE_SPECIAL
> select ARCH_HAS_SET_DIRECT_MAP
> @@ -57,6 +58,7 @@ config RISCV
> select HAVE_DMA_CONTIGUOUS if MMU
> select HAVE_EBPF_JIT if MMU
> select HAVE_FUTEX_CMPXCHG if FUTEX
> + select HAVE_GCC_PLUGINS
> select HAVE_GENERIC_VDSO if MMU && 64BIT
> select HAVE_PCI
> select HAVE_PERF_EVENTS
> diff --git a/arch/riscv/boot/Makefile b/arch/riscv/boot/Makefile
> index 3530c59b3ea7..c59fca695f9d 100644
> --- a/arch/riscv/boot/Makefile
> +++ b/arch/riscv/boot/Makefile
> @@ -14,6 +14,8 @@
> # Based on the ia64 and arm64 boot/Makefile.
> #
>
> +KCOV_INSTRUMENT := n
> +
> OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
>
> targets := Image loader
> diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
> index 29cf052f6541..4b0d3bcc44e5 100644
> --- a/arch/riscv/kernel/vdso/Makefile
> +++ b/arch/riscv/kernel/vdso/Makefile
> @@ -29,6 +29,7 @@ CPPFLAGS_vdso.lds += -P -C -U$(ARCH)
>
> # Disable gcov profiling for VDSO code
> GCOV_PROFILE := n
> +KCOV_INSTRUMENT := n
>
> # Force dependency
> $(obj)/vdso.o: $(obj)/vdso.so
> diff --git a/arch/riscv/mm/Makefile b/arch/riscv/mm/Makefile
> index 363ef01c30b1..c0185e556ca5 100644
> --- a/arch/riscv/mm/Makefile
> +++ b/arch/riscv/mm/Makefile
> @@ -5,6 +5,8 @@ ifdef CONFIG_FTRACE
> CFLAGS_REMOVE_init.o = -pg
> endif
>
> +KCOV_INSTRUMENT_init.o := n
> +
> obj-y += init.o
> obj-y += extable.o
> obj-$(CONFIG_MMU) += fault.o pageattr.o
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-07-11 4:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 18:39 [PATCH] riscv: enable kcov Tobias Klauser
2020-06-25 18:45 ` Dmitry Vyukov
2020-06-26 12:02 ` Tobias Klauser
2020-06-26 12:40 ` [PATCH v2] riscv: Allow building with kcov coverage Tobias Klauser
2020-06-26 14:28 ` Dmitry Vyukov
2020-07-11 4:27 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-5606ac04-c52e-4211-bd30-fce86df7f0fd@palmerdabbelt-glaptop1 \
--to=palmer@dabbelt.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn.topel@gmail.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).