From: Samuel Holland <samuel.holland@sifive.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>
Cc: Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Samuel Holland <samuel.holland@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: [PATCH v2 1/4] gpio: sifive: Directly use the device's fwnode
Date: Wed, 19 Jul 2023 09:34:42 -0700 [thread overview]
Message-ID: <20230719163446.1398961-2-samuel.holland@sifive.com> (raw)
In-Reply-To: <20230719163446.1398961-1-samuel.holland@sifive.com>
There is no need to convert dev->of_node back to a fwnode_handle.
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---
Changes in v2:
- New patch for v2
drivers/gpio/gpio-sifive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
index 745e5f67254e..ab32c952c61b 100644
--- a/drivers/gpio/gpio-sifive.c
+++ b/drivers/gpio/gpio-sifive.c
@@ -254,7 +254,7 @@ static int sifive_gpio_probe(struct platform_device *pdev)
chip->gc.owner = THIS_MODULE;
girq = &chip->gc.irq;
gpio_irq_chip_set_chip(girq, &sifive_gpio_irqchip);
- girq->fwnode = of_node_to_fwnode(node);
+ girq->fwnode = dev->fwnode;
girq->parent_domain = parent;
girq->child_to_parent_hwirq = sifive_gpio_child_to_parent_hwirq;
girq->handler = handle_bad_irq;
--
2.40.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-19 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 16:34 [PATCH v2 0/4] gpio: sifive: Module support Samuel Holland
2023-07-19 16:34 ` Samuel Holland [this message]
2023-07-19 16:44 ` [PATCH v2 1/4] gpio: sifive: Directly use the device's fwnode Andy Shevchenko
2023-07-19 16:34 ` [PATCH v2 2/4] gpio: sifive: Look up IRQs only once during probe Samuel Holland
2023-07-19 16:48 ` Andy Shevchenko
2023-07-19 16:55 ` Samuel Holland
2023-07-19 16:34 ` [PATCH v2 3/4] gpio: sifive: Get the parent IRQ's domain from its irq_data Samuel Holland
2023-07-19 16:54 ` Andy Shevchenko
2023-07-19 17:03 ` Samuel Holland
2023-07-19 17:21 ` Andy Shevchenko
2023-07-19 16:34 ` [PATCH v2 4/4] gpio: sifive: Allow building the driver as a module Samuel Holland
2023-07-19 16:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719163446.1398961-2-samuel.holland@sifive.com \
--to=samuel.holland@sifive.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=emil.renner.berthing@canonical.com \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).