From: Andy Shevchenko <andy@kernel.org>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 3/4] gpio: sifive: Get the parent IRQ's domain from its irq_data
Date: Wed, 19 Jul 2023 19:54:22 +0300 [thread overview]
Message-ID: <ZLgVPv7zdoaiUCU6@smile.fi.intel.com> (raw)
In-Reply-To: <20230719163446.1398961-4-samuel.holland@sifive.com>
On Wed, Jul 19, 2023 at 09:34:44AM -0700, Samuel Holland wrote:
> Do not parse the devicetree again when the data is already available
> from the IRQ subsystem. This follows the example of the ThunderX and
> X-Gene GPIO drivers. The ngpio check is needed to avoid a possible
> out-of-bounds read.
...
> - girq->parent_domain = parent;
> + girq->parent_domain = irq_get_irq_data(chip->irq_number[0])->domain;
For the sake of readability I would like to leave parent variable
and assign it beforehand somewhere upper in the code.
Also, can irq_get_irq_data() return NULL? Needs a comment on top
of that assignment or an additional check.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-19 16:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 16:34 [PATCH v2 0/4] gpio: sifive: Module support Samuel Holland
2023-07-19 16:34 ` [PATCH v2 1/4] gpio: sifive: Directly use the device's fwnode Samuel Holland
2023-07-19 16:44 ` Andy Shevchenko
2023-07-19 16:34 ` [PATCH v2 2/4] gpio: sifive: Look up IRQs only once during probe Samuel Holland
2023-07-19 16:48 ` Andy Shevchenko
2023-07-19 16:55 ` Samuel Holland
2023-07-19 16:34 ` [PATCH v2 3/4] gpio: sifive: Get the parent IRQ's domain from its irq_data Samuel Holland
2023-07-19 16:54 ` Andy Shevchenko [this message]
2023-07-19 17:03 ` Samuel Holland
2023-07-19 17:21 ` Andy Shevchenko
2023-07-19 16:34 ` [PATCH v2 4/4] gpio: sifive: Allow building the driver as a module Samuel Holland
2023-07-19 16:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLgVPv7zdoaiUCU6@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=emil.renner.berthing@canonical.com \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).