From: Conor Dooley <conor@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jack Zhu <jack.zhu@starfivetech.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
Date: Mon, 22 Jan 2024 08:24:51 +0000 [thread overview]
Message-ID: <20240122-uncivil-almost-631137081fd9@spud> (raw)
In-Reply-To: <BJXPR01MB0662E6EEEEF888BD90A1FCE5F275A@BJXPR01MB0662.CHNPR01.prod.partner.outlook.cn>
[-- Attachment #1.1: Type: text/plain, Size: 1185 bytes --]
On Mon, Jan 22, 2024 at 01:33:56AM +0000, Changhuang Liang wrote:
>
> > On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > the content is safe
> > >
> > > Hi , Conor
> > >
> > > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver
> > > > and yaml property names
> > > >
> > > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > > > Drop some unused properties for clocks, resets and interrupts for
> > > > > StarFive JH7110 camera subsystem.
> > > >
> > > > What do you mean "unused"?
> > > >
> > > > Do these clocks etc exist but are not used by the driver?
> > > >
> > > > Or do they not exist at all?
> > > >
> > > > The two are very different!
> >
> > > These clocks etc exist but are not used by the driver.
> >
> > That's not an acceptable reason for removing them from the binding. If they
> > exist, they should be documented, regardless of whether the driver makes use
> > of them. NAK.
>
> If so, how to avoid the warning of dtbs_check.
By also adding the clocks, resets and interrupts to the dts.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-01-22 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 10:06 [PATCH v1 0/2] Add camera subsystem for StarFive Changhuang Liang
2024-01-19 10:06 ` [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names Changhuang Liang
2024-01-19 10:16 ` Conor Dooley
2024-01-19 12:57 ` 回复: " Changhuang Liang
2024-01-19 13:58 ` Conor Dooley
2024-01-22 1:33 ` 回复: " Changhuang Liang
2024-01-22 8:24 ` Conor Dooley [this message]
2024-03-27 18:03 ` Conor Dooley
2024-03-28 1:06 ` 回复: " Changhuang Liang
2024-03-28 6:28 ` Conor Dooley
2024-01-19 10:06 ` [PATCH v1 2/2] riscv: dts: starfive: jh7110: Add camera subsystem nodes Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122-uncivil-almost-631137081fd9@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).