From: Conor Dooley <conor@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jack Zhu <jack.zhu@starfivetech.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: 回复: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
Date: Thu, 28 Mar 2024 06:28:32 +0000 [thread overview]
Message-ID: <C3D2F0B5-CB35-488E-842E-D049CA067475@kernel.org> (raw)
In-Reply-To: <SHXPR01MB0671EA5AED87CE14113148E7F23BA@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn>
On 28 March 2024 01:06:42 GMT, Changhuang Liang <changhuang.liang@starfivetech.com> wrote:
>Hi, Conor,
>
>> On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
>[...]
>> > > > > > Do these clocks etc exist but are not used by the driver?
>> > > > > >
>> > > > > > Or do they not exist at all?
>> > > > > >
>> > > > > > The two are very different!
>> > > >
>> > > > > These clocks etc exist but are not used by the driver.
>> > > >
>> > > > That's not an acceptable reason for removing them from the
>> > > > binding. If they exist, they should be documented, regardless of
>> > > > whether the driver makes use of them. NAK.
>> > >
>> > > If so, how to avoid the warning of dtbs_check.
>> >
>> > By also adding the clocks, resets and interrupts to the dts.
>>
>> Going through patchwork stuff now that the merge window is done. I'm gonna
>> mark the dts patch as changes requeted. The binding (and dts) should
>> describe all of the clocks the hardware has, whether or not you choose to use
>> them all in software does not matter. Can you please resend the dts patch,
>> with all of the clocks, resets and interrupts present?
>>
>
>You have applied the dts patch.
>https://lore.kernel.org/all/20240219032741.18387-1-changhuang.liang@starfivetech.com/
Oh, sorry for the noise then. I guess I was
mislead by patchwork marking this as new :)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-28 6:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 10:06 [PATCH v1 0/2] Add camera subsystem for StarFive Changhuang Liang
2024-01-19 10:06 ` [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names Changhuang Liang
2024-01-19 10:16 ` Conor Dooley
2024-01-19 12:57 ` 回复: " Changhuang Liang
2024-01-19 13:58 ` Conor Dooley
2024-01-22 1:33 ` 回复: " Changhuang Liang
2024-01-22 8:24 ` Conor Dooley
2024-03-27 18:03 ` Conor Dooley
2024-03-28 1:06 ` 回复: " Changhuang Liang
2024-03-28 6:28 ` Conor Dooley [this message]
2024-01-19 10:06 ` [PATCH v1 2/2] riscv: dts: starfive: jh7110: Add camera subsystem nodes Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C3D2F0B5-CB35-488E-842E-D049CA067475@kernel.org \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).