* [PATCH -fixes V2] riscv: mm: remove redundant parameter of create_fdt_early_page_table
@ 2023-04-26 10:00 Song Shuai
2023-04-27 10:15 ` Conor Dooley
2023-05-01 22:44 ` Palmer Dabbelt
0 siblings, 2 replies; 4+ messages in thread
From: Song Shuai @ 2023-04-26 10:00 UTC (permalink / raw)
To: paul.walmsley, palmer, aou, alexghiti, heiko, conor.dooley,
guoren, anshuman.khandual, mick, samuel
Cc: linux-riscv, linux-kernel, Song Shuai
create_fdt_early_page_table() explicitly uses early_pg_dir for
32-bit fdt mapping and the pgdir parameter is redundant here.
So remove it and its caller.
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Signed-off-by: Song Shuai <suagrfillet@gmail.com>
---
Changes in V1:
https://lore.kernel.org/linux-riscv/83540cb1-0c9b-f572-849a-cb100437d049@ghiti.fr/T/#t
- fix the typo
---
arch/riscv/mm/init.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index 0f14f4a8d179..6ebb75a9a6b9 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -843,8 +843,7 @@ static void __init create_kernel_page_table(pgd_t *pgdir, bool early)
* this means 2 PMD entries whereas for 32-bit kernel, this is only 1 PGDIR
* entry.
*/
-static void __init create_fdt_early_page_table(pgd_t *pgdir,
- uintptr_t fix_fdt_va,
+static void __init create_fdt_early_page_table(uintptr_t fix_fdt_va,
uintptr_t dtb_pa)
{
uintptr_t pa = dtb_pa & ~(PMD_SIZE - 1);
@@ -1034,8 +1033,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa)
create_kernel_page_table(early_pg_dir, true);
/* Setup early mapping for FDT early scan */
- create_fdt_early_page_table(early_pg_dir,
- __fix_to_virt(FIX_FDT), dtb_pa);
+ create_fdt_early_page_table(__fix_to_virt(FIX_FDT), dtb_pa);
/*
* Bootime fixmap only can handle PMD_SIZE mapping. Thus, boot-ioremap
--
2.20.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -fixes V2] riscv: mm: remove redundant parameter of create_fdt_early_page_table
2023-04-26 10:00 [PATCH -fixes V2] riscv: mm: remove redundant parameter of create_fdt_early_page_table Song Shuai
@ 2023-04-27 10:15 ` Conor Dooley
2023-04-27 10:22 ` Song Shuai
2023-05-01 22:44 ` Palmer Dabbelt
1 sibling, 1 reply; 4+ messages in thread
From: Conor Dooley @ 2023-04-27 10:15 UTC (permalink / raw)
To: Song Shuai
Cc: paul.walmsley, palmer, aou, alexghiti, heiko, guoren,
anshuman.khandual, mick, samuel, linux-riscv, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2022 bytes --]
On Wed, Apr 26, 2023 at 06:00:09PM +0800, Song Shuai wrote:
> create_fdt_early_page_table() explicitly uses early_pg_dir for
> 32-bit fdt mapping and the pgdir parameter is redundant here.
> So remove it and its caller.
>
> Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Signed-off-by: Song Shuai <suagrfillet@gmail.com>
Whoops, I missed the v2, so copy-pasting:
"and its caller" sounds like you're removing the caller itself when
that's not what you're doing!
I am certainly not suggesting that you resubmit because of that though.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Automation failed to apply this which is a bit weird. What was the
base-commit?
Cheers,
Conor.
> ---
> Changes in V1:
> https://lore.kernel.org/linux-riscv/83540cb1-0c9b-f572-849a-cb100437d049@ghiti.fr/T/#t
> - fix the typo
> ---
> arch/riscv/mm/init.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 0f14f4a8d179..6ebb75a9a6b9 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -843,8 +843,7 @@ static void __init create_kernel_page_table(pgd_t *pgdir, bool early)
> * this means 2 PMD entries whereas for 32-bit kernel, this is only 1 PGDIR
> * entry.
> */
> -static void __init create_fdt_early_page_table(pgd_t *pgdir,
> - uintptr_t fix_fdt_va,
> +static void __init create_fdt_early_page_table(uintptr_t fix_fdt_va,
> uintptr_t dtb_pa)
> {
> uintptr_t pa = dtb_pa & ~(PMD_SIZE - 1);
> @@ -1034,8 +1033,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa)
> create_kernel_page_table(early_pg_dir, true);
>
> /* Setup early mapping for FDT early scan */
> - create_fdt_early_page_table(early_pg_dir,
> - __fix_to_virt(FIX_FDT), dtb_pa);
> + create_fdt_early_page_table(__fix_to_virt(FIX_FDT), dtb_pa);
>
> /*
> * Bootime fixmap only can handle PMD_SIZE mapping. Thus, boot-ioremap
> --
> 2.20.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -fixes V2] riscv: mm: remove redundant parameter of create_fdt_early_page_table
2023-04-27 10:15 ` Conor Dooley
@ 2023-04-27 10:22 ` Song Shuai
0 siblings, 0 replies; 4+ messages in thread
From: Song Shuai @ 2023-04-27 10:22 UTC (permalink / raw)
To: Conor Dooley
Cc: paul.walmsley, palmer, aou, alexghiti, heiko, guoren,
anshuman.khandual, mick, samuel, linux-riscv, linux-kernel
Conor Dooley <conor.dooley@microchip.com> 于2023年4月27日周四 10:15写道:
>
> On Wed, Apr 26, 2023 at 06:00:09PM +0800, Song Shuai wrote:
> > create_fdt_early_page_table() explicitly uses early_pg_dir for
> > 32-bit fdt mapping and the pgdir parameter is redundant here.
> > So remove it and its caller.
> >
> > Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> > Signed-off-by: Song Shuai <suagrfillet@gmail.com>
>
> Whoops, I missed the v2, so copy-pasting:
>
> "and its caller" sounds like you're removing the caller itself when
> that's not what you're doing!
> I am certainly not suggesting that you resubmit because of that though.
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Automation failed to apply this which is a bit weird. What was the
> base-commit?
commit 1b50f956c8fe `riscv: No need to relocate the dtb as it lies in
the fixmap region` in riscv/linux fixes branch.
>
> Cheers,
> Conor.
>
> > ---
> > Changes in V1:
> > https://lore.kernel.org/linux-riscv/83540cb1-0c9b-f572-849a-cb100437d049@ghiti.fr/T/#t
> > - fix the typo
> > ---
> > arch/riscv/mm/init.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> > index 0f14f4a8d179..6ebb75a9a6b9 100644
> > --- a/arch/riscv/mm/init.c
> > +++ b/arch/riscv/mm/init.c
> > @@ -843,8 +843,7 @@ static void __init create_kernel_page_table(pgd_t *pgdir, bool early)
> > * this means 2 PMD entries whereas for 32-bit kernel, this is only 1 PGDIR
> > * entry.
> > */
> > -static void __init create_fdt_early_page_table(pgd_t *pgdir,
> > - uintptr_t fix_fdt_va,
> > +static void __init create_fdt_early_page_table(uintptr_t fix_fdt_va,
> > uintptr_t dtb_pa)
> > {
> > uintptr_t pa = dtb_pa & ~(PMD_SIZE - 1);
> > @@ -1034,8 +1033,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa)
> > create_kernel_page_table(early_pg_dir, true);
> >
> > /* Setup early mapping for FDT early scan */
> > - create_fdt_early_page_table(early_pg_dir,
> > - __fix_to_virt(FIX_FDT), dtb_pa);
> > + create_fdt_early_page_table(__fix_to_virt(FIX_FDT), dtb_pa);
> >
> > /*
> > * Bootime fixmap only can handle PMD_SIZE mapping. Thus, boot-ioremap
> > --
> > 2.20.1
> >
--
Thanks,
Song
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -fixes V2] riscv: mm: remove redundant parameter of create_fdt_early_page_table
2023-04-26 10:00 [PATCH -fixes V2] riscv: mm: remove redundant parameter of create_fdt_early_page_table Song Shuai
2023-04-27 10:15 ` Conor Dooley
@ 2023-05-01 22:44 ` Palmer Dabbelt
1 sibling, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2023-05-01 22:44 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, aou, alexghiti, heiko,
Conor Dooley, guoren, anshuman.khandual, mick, samuel,
Song Shuai
Cc: linux-riscv, linux-kernel
On Wed, 26 Apr 2023 18:00:09 +0800, Song Shuai wrote:
> create_fdt_early_page_table() explicitly uses early_pg_dir for
> 32-bit fdt mapping and the pgdir parameter is redundant here.
> So remove it and its caller.
>
>
Applied, thanks!
[1/1] riscv: mm: remove redundant parameter of create_fdt_early_page_table
https://git.kernel.org/palmer/c/e4ef93edd4e0
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-02 4:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-26 10:00 [PATCH -fixes V2] riscv: mm: remove redundant parameter of create_fdt_early_page_table Song Shuai
2023-04-27 10:15 ` Conor Dooley
2023-04-27 10:22 ` Song Shuai
2023-05-01 22:44 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).