From: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: u.kleine-koenig@pengutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, dlan@gentoo.org,
inochiama@outlook.com
Subject: Re: [PATCH v4 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC
Date: Tue, 5 Mar 2024 09:46:32 +0800 [thread overview]
Message-ID: <CAJRtX8R-j6BfJC6We0Xh1e0sYe6_CyUjbznf7e-kNmcF0=Bcjw@mail.gmail.com> (raw)
In-Reply-To: <0c957a95-9f82-41c2-8e2c-0b5bf4b061a4@linaro.org>
On Mon, Mar 4, 2024 at 11:02 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 04/03/2024 14:40, Jingbao Qiu wrote:
> > On Mon, Mar 4, 2024 at 6:15 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 04/03/2024 10:02, Jingbao Qiu wrote:
> >>> Implement the PWM driver for CV1800.
> >>>
> >>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> >>
> >> ...
> >>
> >>> +
> >>> + ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
> >>> + priv->clk);
> >>> + if (ret) {
> >>> + clk_rate_exclusive_put(priv->clk);
> >>> + return ret;
> >>
> >> Please test this path - you have double put.
> >>
> >
> > Thank you for your reply. You're right. If the
> > devm_add_action_or_reset() function
> > fails to add an action, it will call the action.
> >
> > By the way, if I need to resend the patch, should I wait for the
> > maintainer to review it, or
> > should I immediately correct this error and resend it.
>
> I recommend one patchset per day.
>
Thank you for your suggestion.
Best regards,
Jingbao Qiu
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-05 1:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 8:59 [PATCH v4 0/2] riscv: pwm: sophgo: add pwm support for CV1800 Jingbao Qiu
2024-03-04 8:59 ` [PATCH v4 1/2] dt-bindings: pwm: sophgo: add pwm for Sophgo CV1800 series SoC Jingbao Qiu
2024-03-04 9:02 ` [PATCH v4 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC Jingbao Qiu
2024-03-04 10:14 ` Krzysztof Kozlowski
2024-03-04 13:40 ` Jingbao Qiu
2024-03-04 15:02 ` Krzysztof Kozlowski
2024-03-05 1:46 ` Jingbao Qiu [this message]
2024-03-04 15:37 ` Uwe Kleine-König
2024-03-05 9:19 ` Jingbao Qiu
2024-03-12 8:07 ` Jingbao Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJRtX8R-j6BfJC6We0Xh1e0sYe6_CyUjbznf7e-kNmcF0=Bcjw@mail.gmail.com' \
--to=qiujingbao.dlmu@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).