From: olof@lixom.net (Olof Johansson) To: linux-riscv@lists.infradead.org Subject: [PATCH] RISC-V: Fix raw_copy_{to,from}_user() Date: Thu, 15 Nov 2018 12:27:42 -0800 [thread overview] Message-ID: <CAOesGMgCM57JNn2_MV8PL+zu6h2i3=saawbdmA3rgEJBUOfreQ@mail.gmail.com> (raw) In-Reply-To: <mhng-4c28d7f1-e034-4506-9ace-40fc2abd1668@palmer-si-x1c4> On Thu, Nov 15, 2018 at 6:59 AM Palmer Dabbelt <palmer@sifive.com> wrote: > > On Wed, 14 Nov 2018 16:27:55 PST (-0800), Olof Johansson wrote: > > Sparse highlighted it, and appears to be a pure bug (from vs to). > > > > ./arch/riscv/include/asm/uaccess.h:403:35: warning: incorrect type in argument 1 (different address spaces) > > ./arch/riscv/include/asm/uaccess.h:403:39: warning: incorrect type in argument 2 (different address spaces) > > ./arch/riscv/include/asm/uaccess.h:409:37: warning: incorrect type in argument 1 (different address spaces) > > ./arch/riscv/include/asm/uaccess.h:409:41: warning: incorrect type in argument 2 (different address spaces) > > > > Signed-off-by: Olof Johansson <olof@lixom.net> > > --- > > arch/riscv/include/asm/uaccess.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/riscv/include/asm/uaccess.h b/arch/riscv/include/asm/uaccess.h > > index 473cfc84e412f..8c3e3e3c8be12 100644 > > --- a/arch/riscv/include/asm/uaccess.h > > +++ b/arch/riscv/include/asm/uaccess.h > > @@ -400,13 +400,13 @@ extern unsigned long __must_check __asm_copy_from_user(void *to, > > static inline unsigned long > > raw_copy_from_user(void *to, const void __user *from, unsigned long n) > > { > > - return __asm_copy_to_user(to, from, n); > > + return __asm_copy_from_user(to, from, n); > > } > > > > static inline unsigned long > > raw_copy_to_user(void __user *to, const void *from, unsigned long n) > > { > > - return __asm_copy_from_user(to, from, n); > > + return __asm_copy_to_user(to, from, n); > > } > > > > extern long strncpy_from_user(char *dest, const char __user *src, long count); > > Oh, no idea how I missed that one. This looks like it's been in for a long > time, so I'm surprised anything works at all! Actually, it boils down to a memcpy either way, it's just that exceptions and access control isn't handled right. So as long as you always do valid copying you'll luck out. > I'm going to add a stable CC and PR this to Linus this week, assuming I get > some time to at least give it a minimal test. > > Thanks for catching this! Cool, sounds good. -Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net> To: Palmer Dabbelt <palmer@sifive.com> Cc: linux-riscv@lists.infradead.org, Albert Ou <aou@eecs.berkeley.edu>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] RISC-V: Fix raw_copy_{to,from}_user() Date: Thu, 15 Nov 2018 12:27:42 -0800 [thread overview] Message-ID: <CAOesGMgCM57JNn2_MV8PL+zu6h2i3=saawbdmA3rgEJBUOfreQ@mail.gmail.com> (raw) Message-ID: <20181115202742.zSteqHupzL2gbnxiBraXd9eXmdILXSLUvPIzLw2JjU4@z> (raw) In-Reply-To: <mhng-4c28d7f1-e034-4506-9ace-40fc2abd1668@palmer-si-x1c4> On Thu, Nov 15, 2018 at 6:59 AM Palmer Dabbelt <palmer@sifive.com> wrote: > > On Wed, 14 Nov 2018 16:27:55 PST (-0800), Olof Johansson wrote: > > Sparse highlighted it, and appears to be a pure bug (from vs to). > > > > ./arch/riscv/include/asm/uaccess.h:403:35: warning: incorrect type in argument 1 (different address spaces) > > ./arch/riscv/include/asm/uaccess.h:403:39: warning: incorrect type in argument 2 (different address spaces) > > ./arch/riscv/include/asm/uaccess.h:409:37: warning: incorrect type in argument 1 (different address spaces) > > ./arch/riscv/include/asm/uaccess.h:409:41: warning: incorrect type in argument 2 (different address spaces) > > > > Signed-off-by: Olof Johansson <olof@lixom.net> > > --- > > arch/riscv/include/asm/uaccess.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/riscv/include/asm/uaccess.h b/arch/riscv/include/asm/uaccess.h > > index 473cfc84e412f..8c3e3e3c8be12 100644 > > --- a/arch/riscv/include/asm/uaccess.h > > +++ b/arch/riscv/include/asm/uaccess.h > > @@ -400,13 +400,13 @@ extern unsigned long __must_check __asm_copy_from_user(void *to, > > static inline unsigned long > > raw_copy_from_user(void *to, const void __user *from, unsigned long n) > > { > > - return __asm_copy_to_user(to, from, n); > > + return __asm_copy_from_user(to, from, n); > > } > > > > static inline unsigned long > > raw_copy_to_user(void __user *to, const void *from, unsigned long n) > > { > > - return __asm_copy_from_user(to, from, n); > > + return __asm_copy_to_user(to, from, n); > > } > > > > extern long strncpy_from_user(char *dest, const char __user *src, long count); > > Oh, no idea how I missed that one. This looks like it's been in for a long > time, so I'm surprised anything works at all! Actually, it boils down to a memcpy either way, it's just that exceptions and access control isn't handled right. So as long as you always do valid copying you'll luck out. > I'm going to add a stable CC and PR this to Linus this week, assuming I get > some time to at least give it a minimal test. > > Thanks for catching this! Cool, sounds good. -Olof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-15 20:27 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-15 0:27 [PATCH] RISC-V: Fix raw_copy_{to,from}_user() Olof Johansson 2018-11-15 0:27 ` Olof Johansson 2018-11-15 14:59 ` Palmer Dabbelt 2018-11-15 14:59 ` Palmer Dabbelt 2018-11-15 20:27 ` Olof Johansson [this message] 2018-11-15 20:27 ` Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOesGMgCM57JNn2_MV8PL+zu6h2i3=saawbdmA3rgEJBUOfreQ@mail.gmail.com' \ --to=olof@lixom.net \ --cc=linux-riscv@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).