From: Daniel Wagner <dwagner@suse.de>
To: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH rt-tests v2 04/14] rt-util: Copy command line before getopt_long() is called
Date: Mon, 15 Mar 2021 09:56:47 +0100 [thread overview]
Message-ID: <20210315085647.6extplrdianzsb4b@beryllium.lan> (raw)
In-Reply-To: <da896064-9c42-9e26-c8e6-2758c28c64cf@redhat.com>
On Mon, Mar 15, 2021 at 01:47:22AM -0400, John Kacur wrote:
>
>
> On Fri, 5 Mar 2021, Daniel Wagner wrote:
>
> > By default, getopt_long() permutes the contents of argv as it scans,
> > so that eventually all the nonoptions are at the end. This is
> > confusing in the JSON output, thus copy the command line before we
> > call getopt_long().
> >
> > Introduce a rt_init() which copies the command line. This makes also
> > rt_write_json() function arguments a bit cleaner.
> >
> > Signed-off-by: Daniel Wagner <dwagner@suse.de>
> > ---
> > src/cyclictest/cyclictest.c | 3 +-
> > src/include/rt-utils.h | 7 +++--
> > src/lib/rt-utils.c | 45 ++++++++++++---------------
> > src/oslat/oslat.c | 5 +--
> > src/pmqtest/pmqtest.c | 3 +-
> > src/ptsematest/ptsematest.c | 3 +-
> > src/rt-migrate-test/rt-migrate-test.c | 3 +-
> > src/sched_deadline/cyclicdeadline.c | 4 ++-
> > src/signaltest/signaltest.c | 3 +-
> > src/sigwaittest/sigwaittest.c | 3 +-
> > src/svsematest/svsematest.c | 3 +-
> > 11 files changed, 44 insertions(+), 38 deletions(-)
> >
> > diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> > index c43dd7cbbd64..3f3b91bab53b 100644
> > --- a/src/cyclictest/cyclictest.c
> > +++ b/src/cyclictest/cyclictest.c
> > @@ -1778,6 +1778,7 @@ int main(int argc, char **argv)
> > int i, ret = -1;
> > int status;
> >
> > + rt_init(argc, argv);
>
> Why should we call this if we're not using formatted output?
Yes unfortunately. We only know after we used getopt_long() that we should
have stored argv, kind of chicken-egg situation.
next prev parent reply other threads:[~2021-03-15 8:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 7:34 [PATCH rt-tests v2 00/14] JSON cleanups and more tests updated Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 01/14] cyclictest: Fix printf format specifier Daniel Wagner
2021-03-14 22:45 ` John Kacur
2021-03-15 8:57 ` Daniel Wagner
2021-03-15 8:58 ` Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 02/14] cyclicdeadline.c: " Daniel Wagner
2021-03-14 22:45 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 03/14] signaltest: Add missing --output usage info Daniel Wagner
2021-03-14 22:47 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 04/14] rt-util: Copy command line before getopt_long() is called Daniel Wagner
2021-03-15 5:47 ` John Kacur
2021-03-15 8:56 ` Daniel Wagner [this message]
2021-03-15 14:41 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 05/14] rt-util: Add start time of test execution for JSON output Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 06/14] rt-util: Add return_code to common section of " Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 07/14] pip_stress: Move test result output to main Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 08/14] pip_stress: Return failure code if test fails Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 09/14] pip_stress: Prepare arg parser to accept only long options Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 10/14] pip_stress: Add JSON output feature Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 11/14] pi_stress: Prepare command line parser for long options only Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 12/14] pi_stress: Add JSON output feature Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 13/14] ssdd: Add quiet command line option Daniel Wagner
2021-03-05 7:35 ` [PATCH rt-tests v2 14/14] ssdd: Add JSON output feature Daniel Wagner
2021-03-05 7:41 ` [PATCH rt-tests v2 00/14] JSON cleanups and more tests updated Daniel Wagner
2021-03-05 15:29 ` John Kacur
2021-03-05 15:41 ` Daniel Wagner
2021-03-05 15:51 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315085647.6extplrdianzsb4b@beryllium.lan \
--to=dwagner@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).