From: John Kacur <jkacur@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Clark Williams <williams@redhat.com>, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH rt-tests v2 02/14] cyclicdeadline.c: Fix printf format specifier
Date: Sun, 14 Mar 2021 18:45:50 -0400 (EDT) [thread overview]
Message-ID: <95637c30-bba4-25e4-f342-26871a8260@redhat.com> (raw)
In-Reply-To: <20210305073500.17926-3-dwagner@suse.de>
On Fri, 5 Mar 2021, Daniel Wagner wrote:
> The fields are not uint64 just longs, update the printf format
> specifiers.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> src/sched_deadline/cyclicdeadline.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
> index 33bac8cda898..d7aa9bb5d269 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -18,7 +18,6 @@
> #include <errno.h>
> #include <signal.h>
> #include <getopt.h>
> -#include <inttypes.h>
>
> #include <sys/syscall.h>
> #include <sys/types.h>
> @@ -976,9 +975,9 @@ static void write_stats(FILE *f, void *data)
> for (i = 0; i < nr_threads; i++) {
> s = &sd[i].stat;
> fprintf(f, " \"%u\": {\n", i);
> - fprintf(f, " \"cycles\": %" PRIu64 ",\n", s->cycles);
> - fprintf(f, " \"min\": %" PRIu64 ",\n", s->min);
> - fprintf(f, " \"max\": %" PRIu64 ",\n", s->max);
> + fprintf(f, " \"cycles\": %ld,\n", s->cycles);
> + fprintf(f, " \"min\": %ld,\n", s->min);
> + fprintf(f, " \"max\": %ld\n", s->max);
> fprintf(f, " \"avg\": %.2f\n", s->avg/s->cycles);
> fprintf(f, " }%s\n", i == nr_threads - 1 ? "" : ",");
> }
> --
> 2.30.1
>
>
This has also already been added before.
John
next prev parent reply other threads:[~2021-03-14 22:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 7:34 [PATCH rt-tests v2 00/14] JSON cleanups and more tests updated Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 01/14] cyclictest: Fix printf format specifier Daniel Wagner
2021-03-14 22:45 ` John Kacur
2021-03-15 8:57 ` Daniel Wagner
2021-03-15 8:58 ` Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 02/14] cyclicdeadline.c: " Daniel Wagner
2021-03-14 22:45 ` John Kacur [this message]
2021-03-05 7:34 ` [PATCH rt-tests v2 03/14] signaltest: Add missing --output usage info Daniel Wagner
2021-03-14 22:47 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 04/14] rt-util: Copy command line before getopt_long() is called Daniel Wagner
2021-03-15 5:47 ` John Kacur
2021-03-15 8:56 ` Daniel Wagner
2021-03-15 14:41 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 05/14] rt-util: Add start time of test execution for JSON output Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 06/14] rt-util: Add return_code to common section of " Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 07/14] pip_stress: Move test result output to main Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 08/14] pip_stress: Return failure code if test fails Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 09/14] pip_stress: Prepare arg parser to accept only long options Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 10/14] pip_stress: Add JSON output feature Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 11/14] pi_stress: Prepare command line parser for long options only Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 12/14] pi_stress: Add JSON output feature Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 13/14] ssdd: Add quiet command line option Daniel Wagner
2021-03-05 7:35 ` [PATCH rt-tests v2 14/14] ssdd: Add JSON output feature Daniel Wagner
2021-03-05 7:41 ` [PATCH rt-tests v2 00/14] JSON cleanups and more tests updated Daniel Wagner
2021-03-05 15:29 ` John Kacur
2021-03-05 15:41 ` Daniel Wagner
2021-03-05 15:51 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95637c30-bba4-25e4-f342-26871a8260@redhat.com \
--to=jkacur@redhat.com \
--cc=dwagner@suse.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).