From: Thomas Gleixner <tglx@linutronix.de>
To: Paul Thomas <pthomas8589@gmail.com>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
dunc.mcphie@gmail.com, Anders Roxell <anders.roxell@linaro.org>
Subject: Re: poor cyclictest results with 5.0 series rt for arm64
Date: Wed, 17 Jul 2019 10:03:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907171001150.1767@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAD56B7eswTRxbeA8foXyVVZ7Bd+_y40dtOLkHxuAf4kVge7VDg@mail.gmail.com>
Paul,
On Tue, 16 Jul 2019, Paul Thomas wrote:
> On Tue, Jul 16, 2019 at 7:14 PM Thomas Gleixner <tglx@linutronix.de> wrote:
> > Either that patch is broken or it got broken on forward porting it from
> > 4.19. Need to look with brain awake tomorrow.
>
> Yes! this looks like it fixes it. The hash I see is slightly different:
> b7f42e8fb48cbe38e4c2d0cab48309aadfa6d032
>
> But the name was the same "arch/arm64: Add lazy preempt support"
So, brain works better now. Can you test the patch below?
Thanks,
tglx
8<----------------
diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index 81312fb7f11c..5e2c3b33c20c 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -610,7 +610,7 @@ el1_irq:
#ifdef CONFIG_PREEMPT
ldr x24, [tsk, #TSK_TI_PREEMPT] // get preempt count
- cbnz x24, 2f // preempt count != 0
+ cbz x24, 1f // preempt count != 0
ldr w24, [tsk, #TSK_TI_PREEMPT_LAZY] // get preempt lazy count
cbnz w24, 2f // preempt lazy count != 0
next prev parent reply other threads:[~2019-07-17 8:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 11:18 poor cyclictest results with 5.0 series rt for arm64 Paul Thomas
[not found] ` <CAD56B7c2=95r7r-6tr0Mby8jSeuQPDNSd4LELnUw1LVRn9Rqew@mail.gmail.com>
2019-07-12 11:32 ` Paul Thomas
2019-07-16 20:24 ` Thomas Gleixner
2019-07-16 21:50 ` Paul Thomas
2019-07-16 23:14 ` Thomas Gleixner
2019-07-17 0:44 ` Paul Thomas
2019-07-17 8:03 ` Thomas Gleixner [this message]
2019-07-17 8:10 ` Thomas Gleixner
2019-07-17 9:02 ` Thomas Gleixner
2019-07-17 10:21 ` Thomas Gleixner
2019-07-17 22:28 ` Paul Thomas
2019-08-13 9:53 ` Sebastian Andrzej Siewior
2019-08-13 18:02 ` Paul Thomas
2019-08-14 11:26 ` Sebastian Andrzej Siewior
2019-08-14 16:17 ` [PATCH RT] arm64: preempt: Check preemption level before looking at lazy-preempt Sebastian Andrzej Siewior
2019-08-14 16:17 ` [PATCH RT] x86: " Sebastian Andrzej Siewior
2019-08-14 17:04 ` poor cyclictest results with 5.0 series rt for arm64 Paul Thomas
2019-08-15 8:29 ` Sebastian Andrzej Siewior
2019-08-15 12:33 ` John Ogness
2019-08-15 13:30 ` Paul Thomas
2019-08-15 13:42 ` Sebastian Andrzej Siewior
2019-08-15 13:52 ` Paul Thomas
2019-08-15 14:19 ` Sebastian Andrzej Siewior
2019-08-15 15:12 ` Paul Thomas
2019-08-15 15:15 ` Sebastian Andrzej Siewior
2019-08-15 15:31 ` Paul Thomas
2019-08-15 18:00 ` Paul Thomas
2019-08-15 18:57 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907171001150.1767@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=anders.roxell@linaro.org \
--cc=dunc.mcphie@gmail.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=pthomas8589@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).