* [PATCH] rtc: sirfsoc: Make sysrtc_regmap_config static
@ 2019-04-10 13:43 Yue Haibing
2019-04-12 8:32 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-04-10 13:43 UTC (permalink / raw)
To: a.zummo, alexandre.belloni, baohua
Cc: linux-kernel, linux-arm-kernel, linux-rtc, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/rtc/rtc-sirfsoc.c:282:28: warning:
symbol 'sysrtc_regmap_config' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/rtc/rtc-sirfsoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-sirfsoc.c b/drivers/rtc/rtc-sirfsoc.c
index 2a9e151..9ba28d1 100644
--- a/drivers/rtc/rtc-sirfsoc.c
+++ b/drivers/rtc/rtc-sirfsoc.c
@@ -279,7 +279,7 @@ static const struct of_device_id sirfsoc_rtc_of_match[] = {
{},
};
-const struct regmap_config sysrtc_regmap_config = {
+static const struct regmap_config sysrtc_regmap_config = {
.reg_bits = 32,
.val_bits = 32,
.fast_io = true,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: sirfsoc: Make sysrtc_regmap_config static
2019-04-10 13:43 [PATCH] rtc: sirfsoc: Make sysrtc_regmap_config static Yue Haibing
@ 2019-04-12 8:32 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2019-04-12 8:32 UTC (permalink / raw)
To: Yue Haibing; +Cc: a.zummo, baohua, linux-kernel, linux-arm-kernel, linux-rtc
On 10/04/2019 21:43:36+0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/rtc/rtc-sirfsoc.c:282:28: warning:
> symbol 'sysrtc_regmap_config' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/rtc/rtc-sirfsoc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-12 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 13:43 [PATCH] rtc: sirfsoc: Make sysrtc_regmap_config static Yue Haibing
2019-04-12 8:32 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).