linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: yuankuiz@codeaurora.org
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rtc-owner@vger.kernel.org
Subject: Re: [PATCH] rtc: proc: printf using alarm for alrm
Date: Mon, 10 Dec 2018 18:01:23 +0800	[thread overview]
Message-ID: <6997a28d4752ce340638f3de5a655d4d@codeaurora.org> (raw)
In-Reply-To: <20181206203827.GE8952@piout.net>

On 2018-12-07 04:38 AM, Alexandre Belloni wrote:
> On 06/12/2018 15:22:51+0800, yuankuiz@codeaurora.org wrote:
>> Hi,
>> 
>>     Kindly, this format change formats the rtc dump from:
>>         alrm_time	: 00:00:00
>>         alrm_date	: 1970-01-01
>>         alarm_IRQ	: no
>>         alrm_pending	: no
>> 
>>     to:
>>         alarm time	: 00:00:00
>>         alarm date	: 1970-01-01
>>         alarm IRQ	: no
>>         alarm pending	: no
>> 
> 
> Yes, and this would break the ABI as this file is in procfs. This is 
> not
> something I'm willing to do, especially since this file has been
> deprecated since 2006.

OK. So shall we default it as n like:
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index a819ef0..c51f0e1 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -100,7 +100,7 @@ config RTC_INTF_SYSFS
  config RTC_INTF_PROC
         bool "/proc/driver/rtc (procfs for rtcN)"
         depends on PROC_FS
-       default RTC_CLASS
+       default n
         help
           Say yes here if you want to use your system clock RTC through
           the proc interface, /proc/driver/rtc.


     Thanks,
BR//John Zhao

      reply	other threads:[~2018-12-10 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04  9:29 [PATCH] rtc: proc: printf using alarm for alrm yuankuiz
2018-12-06  7:22 ` yuankuiz
2018-12-06 20:38   ` Alexandre Belloni
2018-12-10 10:01     ` yuankuiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6997a28d4752ce340638f3de5a655d4d@codeaurora.org \
    --to=yuankuiz@codeaurora.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc-owner@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).