linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: yuankuiz@codeaurora.org
To: a.zummo@towertech.it, alexandre.belloni@bootlin.com
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] rtc: proc: printf using alarm for alrm
Date: Tue, 04 Dec 2018 17:29:02 +0800	[thread overview]
Message-ID: <b44225b8e243a70c6ab63a40a3de630d@codeaurora.org> (raw)

Hi,

 From 549bae59445c5ec67dd6a46f3ea4f58966d40c9b

Current the struct rtc_wkalrm is dumped as
"alrm_" by printing converted from the struct
name of "alrm.*" directly. Shall we use the
"alarm *" to replace the "alrm_*" during this
dumping?

Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
---
  drivers/rtc/rtc-proc.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
index a9dd921..d4a3c91 100644
--- a/drivers/rtc/rtc-proc.c
+++ b/drivers/rtc/rtc-proc.c
@@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void 
*offset)

  	err = rtc_read_alarm(rtc, &alrm);
  	if (err == 0) {
-		seq_printf(seq, "alrm_time\t: ");
+		seq_printf(seq, "alarm time\t: ");
  		if ((unsigned int)alrm.time.tm_hour <= 24)
  			seq_printf(seq, "%02d:", alrm.time.tm_hour);
  		else
@@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void 
*offset)
  		else
  			seq_printf(seq, "**\n");

-		seq_printf(seq, "alrm_date\t: ");
+		seq_printf(seq, "alarm date\t: ");
  		if ((unsigned int)alrm.time.tm_year <= 200)
  			seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
  		else
@@ -85,9 +85,9 @@ static int rtc_proc_show(struct seq_file *seq, void 
*offset)
  			seq_printf(seq, "%02d\n", alrm.time.tm_mday);
  		else
  			seq_printf(seq, "**\n");
-		seq_printf(seq, "alarm_IRQ\t: %s\n",
+		seq_printf(seq, "alarm IRQ\t: %s\n",
  				alrm.enabled ? "yes" : "no");
-		seq_printf(seq, "alrm_pending\t: %s\n",
+		seq_printf(seq, "alarm pending\t: %s\n",
  				alrm.pending ? "yes" : "no");
  		seq_printf(seq, "update IRQ enabled\t: %s\n",
  			(rtc->uie_rtctimer.enabled) ? "yes" : "no");
-- 
2.7.4

             reply	other threads:[~2018-12-04  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04  9:29 yuankuiz [this message]
2018-12-06  7:22 ` [PATCH] rtc: proc: printf using alarm for alrm yuankuiz
2018-12-06 20:38   ` Alexandre Belloni
2018-12-10 10:01     ` yuankuiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b44225b8e243a70c6ab63a40a3de630d@codeaurora.org \
    --to=yuankuiz@codeaurora.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).