From: Heiko Carstens <hca@linux.ibm.com>
To: David Laight <David.Laight@aculab.com>
Cc: "'Haowen Bai'" <baihaowen@meizu.com>,
"gor@linux.ibm.com" <gor@linux.ibm.com>,
"agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
"borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
"svens@linux.ibm.com" <svens@linux.ibm.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vineeth Vijayan <vneethv@linux.ibm.com>
Subject: Re: [PATCH] s390: Simplify the calculation of variables
Date: Mon, 4 Apr 2022 11:10:55 +0200 [thread overview]
Message-ID: <Ykq2H+POaGs0GHVU@osiris> (raw)
In-Reply-To: <9ab80e670fb341ddaba51a9cd78203fe@AcuMS.aculab.com>
On Mon, Mar 28, 2022 at 12:15:49PM +0000, David Laight wrote:
> From: Haowen Bai
> > Sent: 28 March 2022 03:36
> >
> > Fix the following coccicheck warnings:
> > ./arch/s390/include/asm/scsw.h:695:47-49: WARNING
> > !A || A && B is equivalent to !A || B
> >
> > Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> > ---
> > arch/s390/include/asm/scsw.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/s390/include/asm/scsw.h b/arch/s390/include/asm/scsw.h
> > index a7c3ccf..f2baac8 100644
> > --- a/arch/s390/include/asm/scsw.h
> > +++ b/arch/s390/include/asm/scsw.h
> > @@ -692,8 +692,7 @@ static inline int scsw_tm_is_valid_pno(union scsw *scsw)
> > return (scsw->tm.fctl != 0) &&
> > (scsw->tm.stctl & SCSW_STCTL_STATUS_PEND) &&
> > (!(scsw->tm.stctl & SCSW_STCTL_INTER_STATUS) ||
> > - ((scsw->tm.stctl & SCSW_STCTL_INTER_STATUS) &&
> > - (scsw->tm.actl & SCSW_ACTL_SUSPENDED)));
> > + (scsw->tm.actl & SCSW_ACTL_SUSPENDED))
> > }
>
> I'd split that impenetrable boolean expression up.
>
> I think this is equivalent:
> if (!scsw->tm.fctl)
> return 0;
> if (!(scsw->tm.stctl & SCSW_STCTL_STATUS_PEND))
> return 0;
> if (!(scsw->tm.stctl & SCSW_STCTL_INTER_STATUS))
> return 1
> if (scsw->tm.actl & SCSW_ACTL_SUSPENDED)
> return 1;
> return 0;
>
> The generated code could even be the same.
Yes, we had the very same discussion here:
https://lore.kernel.org/linux-s390/20210820025159.11914-1-jing.yangyang@zte.com.cn/
Where the outcome also was that it doesn't make sense to replace one
unreadable version with another unreadable version just to get rid of
a warning.
Haowen, could you please resend with a proper readable version, or
alternatively, Vineeth, could you address this please, so this doesn't
come up again?
Thanks!
next prev parent reply other threads:[~2022-04-04 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 2:36 [PATCH] s390: Simplify the calculation of variables Haowen Bai
2022-03-28 5:37 ` kernel test robot
2022-03-28 6:08 ` kernel test robot
2022-03-28 12:15 ` David Laight
2022-04-04 9:10 ` Heiko Carstens [this message]
2022-04-06 2:37 ` [PATCH V2] " Haowen Bai
2022-04-06 8:45 ` Heiko Carstens
2022-04-06 16:44 ` Peter Oberparleiter
2022-04-07 2:16 ` [PATCH V3] " Haowen Bai
2022-04-08 12:53 ` Peter Oberparleiter
2022-04-08 14:32 ` Heiko Carstens
2022-04-07 2:19 ` [PATCH V2] " baihaowen
-- strict thread matches above, loose matches on Subject: below --
2021-03-01 10:32 [PATCH] " Jiapeng Chong
2021-01-26 9:09 Jiapeng Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykq2H+POaGs0GHVU@osiris \
--to=hca@linux.ibm.com \
--cc=David.Laight@aculab.com \
--cc=agordeev@linux.ibm.com \
--cc=baihaowen@meizu.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).