* Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area
@ 2020-05-12 11:40 Markus Elfring
2020-05-12 11:56 ` Lukasz Luba
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-05-12 11:40 UTC (permalink / raw)
To: Bernard Zhao, linux-arm-kernel, linux-pm, linux-samsung-soc
Cc: linux-kernel, opensource.kernel, Krzysztof Kozlowski, Kukjin Kim,
Lukasz Luba
> Maybe dmc->df->lock seems not needed to protect "if (ret)
> & dev_warn" branch. Maybe this change speed up the code a bit.
I suggest to improve also this commit message.
* Please reduce uncertainty.
* An imperative wording is probably preferred, isn't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=152036d1379ffd6985262743dcf6b0f9c75f83a4#n151
* Will it be more appropriate to refer to the transformation “Reduce the lock scope”?
* Would you like to add the tag “Fixes” to the change description?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area
2020-05-12 11:40 [PATCH v2] memory/samsung: reduce unnecessary mutex lock area Markus Elfring
@ 2020-05-12 11:56 ` Lukasz Luba
2020-05-12 12:31 ` Bernard
2020-05-12 12:32 ` [v2] " Markus Elfring
0 siblings, 2 replies; 5+ messages in thread
From: Lukasz Luba @ 2020-05-12 11:56 UTC (permalink / raw)
To: Markus Elfring, Bernard Zhao, linux-arm-kernel, linux-pm,
linux-samsung-soc
Cc: linux-kernel, opensource.kernel, Krzysztof Kozlowski, Kukjin Kim
On 5/12/20 12:40 PM, Markus Elfring wrote:
>> Maybe dmc->df->lock seems not needed to protect "if (ret)
>> & dev_warn" branch. Maybe this change speed up the code a bit.
>
> I suggest to improve also this commit message.
>
> * Please reduce uncertainty.
>
> * An imperative wording is probably preferred, isn't it?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=152036d1379ffd6985262743dcf6b0f9c75f83a4#n151
>
> * Will it be more appropriate to refer to the transformation “Reduce the lock scope”?
>
> * Would you like to add the tag “Fixes” to the change description?
>
> Regards,
> Markus
>
Thank you Markus for providing to Bernard helpful suggestions.
@Bernard please read the link above and send v3
Something like: 'memory/samsung: reduce protected code area in IRQ
handler' for the subject header would be better.
Then in the message explain (without 'maybe') that it will speed-up a
bit this IRQ processing and there is no need to protect return value or
printing.
Regards,
Lukasz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area
2020-05-12 11:56 ` Lukasz Luba
@ 2020-05-12 12:31 ` Bernard
2020-05-12 12:32 ` [v2] " Markus Elfring
1 sibling, 0 replies; 5+ messages in thread
From: Bernard @ 2020-05-12 12:31 UTC (permalink / raw)
To: Lukasz Luba
Cc: Markus Elfring, linux-arm-kernel, linux-pm, linux-samsung-soc,
linux-kernel, opensource.kernel, Krzysztof Kozlowski, Kukjin Kim
From: Lukasz Luba <lukasz.luba@arm.com>
Date: 2020-05-12 19:56:49
To: Markus Elfring <Markus.Elfring@web.de>,Bernard Zhao <bernard@vivo.com>,linux-arm-kernel@lists.infradead.org,linux-pm@vger.kernel.org,linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,opensource.kernel@vivo.com,Krzysztof Kozlowski <krzk@kernel.org>,Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area>
>
>On 5/12/20 12:40 PM, Markus Elfring wrote:
>>> Maybe dmc->df->lock seems not needed to protect "if (ret)
>>> & dev_warn" branch. Maybe this change speed up the code a bit.
>>
>> I suggest to improve also this commit message.
>>
>> * Please reduce uncertainty.
>>
>> * An imperative wording is probably preferred, isn't it?
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=152036d1379ffd6985262743dcf6b0f9c75f83a4#n151
>>
>> * Will it be more appropriate to refer to the transformation “Reduce the lock scope”?
>>
>> * Would you like to add the tag “Fixes” to the change description?
>>
>> Regards,
>> Markus
>>
>
>Thank you Markus for providing to Bernard helpful suggestions.
>
>@Bernard please read the link above and send v3
>
>Something like: 'memory/samsung: reduce protected code area in IRQ
>handler' for the subject header would be better.
>Then in the message explain (without 'maybe') that it will speed-up a
>bit this IRQ processing and there is no need to protect return value or
>printing.
>
>Regards,
>Lukasz
Sure, thank you both Markus & Lukasz for your helpful suggestions, I will read the content
of the link in detail and use that preferred format in my future subsequent submissions.
Regards,
Bernard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2] memory/samsung: reduce unnecessary mutex lock area
2020-05-12 11:56 ` Lukasz Luba
2020-05-12 12:31 ` Bernard
@ 2020-05-12 12:32 ` Markus Elfring
2020-05-12 12:48 ` Lukasz Luba
1 sibling, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-05-12 12:32 UTC (permalink / raw)
To: Lukasz Luba, Bernard Zhao, linux-arm-kernel, linux-pm, linux-samsung-soc
Cc: linux-kernel, opensource.kernel, Krzysztof Kozlowski, Kukjin Kim
> Something like: 'memory/samsung: reduce protected code area in IRQ
> handler' for the subject header would be better.
> Then in the message explain (without 'maybe') that it will speed-up a
> bit this IRQ processing and there is no need to protect return value
> or printing.
Do you tend to prefer smaller lock scopes for nicer run time characteristics?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2] memory/samsung: reduce unnecessary mutex lock area
2020-05-12 12:32 ` [v2] " Markus Elfring
@ 2020-05-12 12:48 ` Lukasz Luba
0 siblings, 0 replies; 5+ messages in thread
From: Lukasz Luba @ 2020-05-12 12:48 UTC (permalink / raw)
To: Markus Elfring, Bernard Zhao, linux-arm-kernel, linux-pm,
linux-samsung-soc
Cc: linux-kernel, opensource.kernel, Krzysztof Kozlowski, Kukjin Kim
On 5/12/20 1:32 PM, Markus Elfring wrote:
>> Something like: 'memory/samsung: reduce protected code area in IRQ
>> handler' for the subject header would be better.
>> Then in the message explain (without 'maybe') that it will speed-up a
>> bit this IRQ processing and there is no need to protect return value
>> or printing.
>
> Do you tend to prefer smaller lock scopes for nicer run time characteristics?
Yes and I am probably not the only one. Of course it consumes time, to
make and test this kind of changes (so it must be in my current scope
of work).
Regards,
Lukasz
>
> Regards,
> Markus
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-12 12:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 11:40 [PATCH v2] memory/samsung: reduce unnecessary mutex lock area Markus Elfring
2020-05-12 11:56 ` Lukasz Luba
2020-05-12 12:31 ` Bernard
2020-05-12 12:32 ` [v2] " Markus Elfring
2020-05-12 12:48 ` Lukasz Luba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).