linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 05/40] scsi: ufs: ufs-exynos: Make stubs 'static inline'
       [not found] <20200723122446.1329773-1-lee.jones@linaro.org>
@ 2020-07-23 12:24 ` Lee Jones
  2020-07-23 12:24 ` [PATCH 06/40] scsi: ufs: ufs-exynos: Demote seemingly unintentional kerneldoc header Lee Jones
  1 sibling, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-07-23 12:24 UTC (permalink / raw)
  To: jejb, martin.petersen
  Cc: linux-kernel, linux-scsi, Lee Jones, Alim Akhtar, Avri Altman,
	Kukjin Kim, Krzysztof Kozlowski, Kiwoong Kim, linux-samsung-soc

Else the compiler complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

 In file included from drivers/scsi/ufs/ufs-exynos.c:23:
 drivers/scsi/ufs/ufs-exynos.h:302:6: warning: no previous prototype for ‘exynos_ufs_cmd_log_start’ [-Wmissing-prototypes]
 302 | void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle,
 | ^~~~~~~~~~~~~~~~~~~~~~~~
 drivers/scsi/ufs/ufs-exynos.h:307:6: warning: no previous prototype for ‘exynos_ufs_cmd_log_end’ [-Wmissing-prototypes]
 307 | void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle,
 | ^~~~~~~~~~~~~~~~~~~~~~
 drivers/scsi/ufs/ufs-exynos.h:312:5: warning: no previous prototype for ‘exynos_ufs_init_dbg’ [-Wmissing-prototypes]
 312 | int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev)
 | ^~~~~~~~~~~~~~~~~~~
 drivers/scsi/ufs/ufs-exynos.h:317:6: warning: no previous prototype for ‘exynos_ufs_dump_info’ [-Wmissing-prototypes]
 317 | void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev)
 | ^~~~~~~~~~~~~~~~~~~~

Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kiwoong Kim <kwmad.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/scsi/ufs/ufs-exynos.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h
index d86d0a0f74780..0908283a76936 100644
--- a/drivers/scsi/ufs/ufs-exynos.h
+++ b/drivers/scsi/ufs/ufs-exynos.h
@@ -299,22 +299,22 @@ void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle,
 int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev);
 void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev);
 #else
-void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle,
-			      struct ufs_hba *hba, int tag)
+static inline void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle,
+					    struct ufs_hba *hba, int tag)
 {
 }
 
-void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle,
-			    struct ufs_hba *hba, int tag)
+static inline void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle,
+					  struct ufs_hba *hba, int tag)
 {
 }
 
-int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev)
+static inline int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev)
 {
 	return 0;
 }
 
-void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev)
+static inline void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev)
 {
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 06/40] scsi: ufs: ufs-exynos: Demote seemingly unintentional kerneldoc header
       [not found] <20200723122446.1329773-1-lee.jones@linaro.org>
  2020-07-23 12:24 ` [PATCH 05/40] scsi: ufs: ufs-exynos: Make stubs 'static inline' Lee Jones
@ 2020-07-23 12:24 ` Lee Jones
  1 sibling, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-07-23 12:24 UTC (permalink / raw)
  To: jejb, martin.petersen
  Cc: linux-kernel, linux-scsi, Lee Jones, Alim Akhtar, Avri Altman,
	Kukjin Kim, Krzysztof Kozlowski, Seungwon Jeon,
	linux-samsung-soc

This is the only use of kerneldoc in the source file and no
descriptions are provided.

Fixes the following W=1 kernel build warning(s):

In file included from  drivers/scsi/ufs/ufs-exynos.c:23:
 drivers/scsi/ufs/ufs-exynos.c:234: warning: Function parameter or member 'ufs' not described in 'exynos_ufs_auto_ctrl_hcc'
 drivers/scsi/ufs/ufs-exynos.c:234: warning: Function parameter or member 'en' not described in 'exynos_ufs_auto_ctrl_hcc'

Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Seungwon Jeon <essuuj@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/scsi/ufs/ufs-exynos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c
index 3c0a50b7e3560..9151c7455acda 100644
--- a/drivers/scsi/ufs/ufs-exynos.c
+++ b/drivers/scsi/ufs/ufs-exynos.c
@@ -224,7 +224,7 @@ static int exynos7_ufs_post_pwr_change(struct exynos_ufs *ufs,
 	return 0;
 }
 
-/**
+/*
  * exynos_ufs_auto_ctrl_hcc - HCI core clock control by h/w
  * Control should be disabled in the below cases
  * - Before host controller S/W reset
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-23 12:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200723122446.1329773-1-lee.jones@linaro.org>
2020-07-23 12:24 ` [PATCH 05/40] scsi: ufs: ufs-exynos: Make stubs 'static inline' Lee Jones
2020-07-23 12:24 ` [PATCH 06/40] scsi: ufs: ufs-exynos: Demote seemingly unintentional kerneldoc header Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).