From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Avri Altman'" <Avri.Altman@wdc.com>,
<linux-scsi@vger.kernel.org>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<beanhuo@micron.com>, <asutoshd@codeaurora.org>,
<cang@codeaurora.org>, <bvanassche@acm.org>,
<grant.jung@samsung.com>, <sc.suh@samsung.com>,
<hy50.seo@samsung.com>, <sh425.lee@samsung.com>
Subject: RE: [RESEND RFC PATCH v4 2/3] ufs: exynos: introduce command history
Date: Sat, 11 Jul 2020 14:58:26 +0900 [thread overview]
Message-ID: <000b01d65748$4b25d240$e17176c0$@samsung.com> (raw)
In-Reply-To: <SN6PR04MB46401E72E1C0C4B8FEBF6156FC640@SN6PR04MB4640.namprd04.prod.outlook.com>
> > + EXYNOS specific, such as vendor specific hardware contexts.
> > +
> > + Select this if you want to get and print the information.
> > + If unsure, say N.
> > diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
> > index f0c5b95..d9e4da7 100644
> > --- a/drivers/scsi/ufs/Makefile
> > +++ b/drivers/scsi/ufs/Makefile
> > @@ -4,7 +4,7 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PCI) += tc-dwc-g210-pci.o
> > ufshcd-dwc.o tc-dwc-g210.
> > obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-dwc-g210-pltfrm.o
> > ufshcd-dwc.o tc-dwc-g210.o
> > obj-$(CONFIG_SCSI_UFS_CDNS_PLATFORM) += cdns-pltfrm.o
> > obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> > -obj-$(CONFIG_SCSI_UFS_EXYNOS) += ufs-exynos.o
> > +obj-$(CONFIG_SCSI_UFS_EXYNOS) += ufs-exynos.o ufs-exynos-dbg.o
> If the key functionality depends on SCSI_UFS_EXYNOS_CMD_LOG, Why not use
> it for make as well, and in your header as well?
I assume somebody including me will add dumping vendor register or another item
in the file. That's why I did.
But currently, you're right and I will do.
Thanks.
Kiwoong Kim
next prev parent reply other threads:[~2020-07-11 5:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200708023153epcas2p1fc18ee2920c5defa2896af34dd62865f@epcas2p1.samsung.com>
2020-07-08 2:23 ` [RESEND RFC PATCH v4 0/3] ufs: exynos: introduce the way to get cmd info Kiwoong Kim
[not found] ` <CGME20200708023155epcas2p3ac30e4b0c24855e0a3466126bba9c612@epcas2p3.samsung.com>
2020-07-08 2:23 ` [RESEND RFC PATCH v4 1/3] ufs: introduce a callback to get info of command completion Kiwoong Kim
2020-07-09 12:06 ` Avri Altman
2020-07-11 5:43 ` Kiwoong Kim
[not found] ` <CGME20200708023156epcas2p416ac7979ed0a0a7a71de1636defb0ec7@epcas2p4.samsung.com>
2020-07-08 2:24 ` [RESEND RFC PATCH v4 2/3] ufs: exynos: introduce command history Kiwoong Kim
2020-07-09 13:27 ` Avri Altman
2020-07-11 5:53 ` Kiwoong Kim
2020-07-11 5:58 ` Kiwoong Kim [this message]
[not found] ` <CGME20200708023156epcas2p188781afcff94b548918326986d58a2d7@epcas2p1.samsung.com>
2020-07-08 2:24 ` [RESEND RFC PATCH v4 3/3] ufs: exynos: implement dbg_register_dump Kiwoong Kim
2020-07-09 12:30 ` Avri Altman
2020-07-11 5:43 ` Kiwoong Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01d65748$4b25d240$e17176c0$@samsung.com' \
--to=kwmad.kim@samsung.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=grant.jung@samsung.com \
--cc=hy50.seo@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sc.suh@samsung.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).