* [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info
@ 2024-04-06 15:50 Colin Ian King
2024-04-09 1:56 ` Martin K. Petersen
2024-04-12 2:05 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-04-06 15:50 UTC (permalink / raw)
To: Khalid Aziz, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
Pointer currTar_Info is being assigned a value that is never read, it
is being re-assigned a few lines later in the start of a following
do-while loop. The assignment is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/FlashPoint.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index 3d9c56ac8224..9e77b8e1ea7c 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -2631,7 +2631,6 @@ static void FPT_sres(u32 port, unsigned char p_card,
WRW_HARPOON((port + hp_fiforead), (unsigned short)0x00);
our_target = (unsigned char)(RD_HARPOON(port + hp_select_id) >> 4);
- currTar_Info = &FPT_sccbMgrTbl[p_card][our_target];
msgRetryCount = 0;
do {
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info
2024-04-06 15:50 [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info Colin Ian King
@ 2024-04-09 1:56 ` Martin K. Petersen
2024-04-12 2:05 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-04-09 1:56 UTC (permalink / raw)
To: Colin Ian King
Cc: Khalid Aziz, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> Pointer currTar_Info is being assigned a value that is never read, it
> is being re-assigned a few lines later in the start of a following
> do-while loop. The assignment is redundant and can be removed.
Applied to 6.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info
2024-04-06 15:50 [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info Colin Ian King
2024-04-09 1:56 ` Martin K. Petersen
@ 2024-04-12 2:05 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-04-12 2:05 UTC (permalink / raw)
To: Khalid Aziz, James E . J . Bottomley, linux-scsi, Colin Ian King
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Sat, 06 Apr 2024 16:50:29 +0100, Colin Ian King wrote:
> Pointer currTar_Info is being assigned a value that is never read, it
> is being re-assigned a few lines later in the start of a following
> do-while loop. The assignment is redundant and can be removed.
>
>
Applied to 6.10/scsi-queue, thanks!
[1/1] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info
https://git.kernel.org/mkp/scsi/c/9bd8e41358a5
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-12 2:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-06 15:50 [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info Colin Ian King
2024-04-09 1:56 ` Martin K. Petersen
2024-04-12 2:05 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).