From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: [PATCH 79/84] xen-scsifront: Call scsi_done() directly
Date: Tue, 21 Sep 2021 10:34:31 -0700 [thread overview]
Message-ID: <20210921173436.3533078-1-bvanassche@acm.org> (raw)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/xen-scsifront.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 0204e314b482..12c10a5e3d93 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -276,7 +276,7 @@ static void scsifront_cdb_cmd_done(struct vscsifrnt_info *info,
if (sense_len)
memcpy(sc->sense_buffer, ring_rsp->sense_buffer, sense_len);
- sc->scsi_done(sc);
+ scsi_done(sc);
}
static void scsifront_sync_cmd_done(struct vscsifrnt_info *info,
@@ -558,7 +558,7 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,
if (err == -ENOMEM)
return SCSI_MLQUEUE_HOST_BUSY;
sc->result = DID_ERROR << 16;
- sc->scsi_done(sc);
+ scsi_done(sc);
return 0;
}
next reply other threads:[~2021-09-21 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 17:34 Bart Van Assche [this message]
2021-09-21 17:34 ` [PATCH 80/84] staging: rts5208: Call scsi_done() directly Bart Van Assche
2021-09-22 6:30 ` Greg Kroah-Hartman
2021-09-22 16:31 ` Bart Van Assche
2021-09-21 17:34 ` [PATCH 81/84] staging: unisys: visorhba: " Bart Van Assche
2021-09-23 6:49 ` Greg Kroah-Hartman
2021-09-21 17:34 ` [PATCH 82/84] target/tcm_loop: " Bart Van Assche
2021-09-21 17:34 ` [PATCH 83/84] usb: " Bart Van Assche
2021-09-21 17:34 ` [PATCH 84/84] scsi_lib: " Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2021-09-18 0:04 [PATCH 00/84] " Bart Van Assche
2021-09-22 16:25 ` [PATCH 79/84] xen-scsifront: " Bart Van Assche
2021-09-23 8:15 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921173436.3533078-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=20210918000607.450448-1-bvanassche@acm.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=jgross@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).