From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: 20210918000607.450448-1-bvanassche@acm.org
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
David Kershner <david.kershner@unisys.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Song Chen <chensong_2000@189.cn>
Subject: Re: [PATCH 81/84] staging: unisys: visorhba: Call scsi_done() directly
Date: Thu, 23 Sep 2021 08:49:23 +0200 [thread overview]
Message-ID: <YUwjc43KkY1sSkhX@kroah.com> (raw)
In-Reply-To: <20210921173436.3533078-3-bvanassche@acm.org>
On Tue, Sep 21, 2021 at 10:34:33AM -0700, Bart Van Assche wrote:
> Conditional statements are faster than indirect calls. Hence call
> scsi_done() directly.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 41f8a72a2a95..6a8fa0587280 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -327,7 +327,7 @@ static int visorhba_abort_handler(struct scsi_cmnd *scsicmd)
> rtn = forward_taskmgmt_command(TASK_MGMT_ABORT_TASK, scsidev);
> if (rtn == SUCCESS) {
> scsicmd->result = DID_ABORT << 16;
> - scsicmd->scsi_done(scsicmd);
> + scsi_done(scsicmd);
> }
> return rtn;
> }
> @@ -354,7 +354,7 @@ static int visorhba_device_reset_handler(struct scsi_cmnd *scsicmd)
> rtn = forward_taskmgmt_command(TASK_MGMT_LUN_RESET, scsidev);
> if (rtn == SUCCESS) {
> scsicmd->result = DID_RESET << 16;
> - scsicmd->scsi_done(scsicmd);
> + scsi_done(scsicmd);
> }
> return rtn;
> }
> @@ -383,7 +383,7 @@ static int visorhba_bus_reset_handler(struct scsi_cmnd *scsicmd)
> rtn = forward_taskmgmt_command(TASK_MGMT_BUS_RESET, scsidev);
> if (rtn == SUCCESS) {
> scsicmd->result = DID_RESET << 16;
> - scsicmd->scsi_done(scsicmd);
> + scsi_done(scsicmd);
> }
> return rtn;
> }
> @@ -476,8 +476,7 @@ static int visorhba_queue_command_lck(struct scsi_cmnd *scsicmd,
> */
> cmdrsp->scsi.handle = insert_location;
>
> - /* save done function that we have call when cmd is complete */
> - scsicmd->scsi_done = visorhba_cmnd_done;
> + WARN_ON_ONCE(visorhba_cmnd_done != scsi_done);
> /* save destination */
> cmdrsp->scsi.vdest.channel = scsidev->channel;
> cmdrsp->scsi.vdest.id = scsidev->id;
> @@ -686,8 +685,7 @@ static void visorhba_serverdown_complete(struct visorhba_devdata *devdata)
> case CMD_SCSI_TYPE:
> scsicmd = pendingdel->sent;
> scsicmd->result = DID_RESET << 16;
> - if (scsicmd->scsi_done)
> - scsicmd->scsi_done(scsicmd);
> + scsi_done(scsicmd);
> break;
> case CMD_SCSITASKMGMT_TYPE:
> cmdrsp = pendingdel->sent;
> @@ -853,7 +851,7 @@ static void complete_scsi_command(struct uiscmdrsp *cmdrsp,
> else
> do_scsi_nolinuxstat(cmdrsp, scsicmd);
>
> - scsicmd->scsi_done(scsicmd);
> + scsi_done(scsicmd);
> }
>
> /*
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-09-23 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 17:34 [PATCH 79/84] xen-scsifront: Call scsi_done() directly Bart Van Assche
2021-09-21 17:34 ` [PATCH 80/84] staging: rts5208: " Bart Van Assche
2021-09-22 6:30 ` Greg Kroah-Hartman
2021-09-22 16:31 ` Bart Van Assche
2021-09-21 17:34 ` [PATCH 81/84] staging: unisys: visorhba: " Bart Van Assche
2021-09-23 6:49 ` Greg Kroah-Hartman [this message]
2021-09-21 17:34 ` [PATCH 82/84] target/tcm_loop: " Bart Van Assche
2021-09-21 17:34 ` [PATCH 83/84] usb: " Bart Van Assche
2021-09-21 17:34 ` [PATCH 84/84] scsi_lib: " Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2021-09-18 0:04 [PATCH 00/84] " Bart Van Assche
2021-09-22 16:25 ` [PATCH 79/84] xen-scsifront: " Bart Van Assche
2021-09-22 16:25 ` [PATCH 81/84] staging: unisys: visorhba: " Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUwjc43KkY1sSkhX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=20210918000607.450448-1-bvanassche@acm.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bvanassche@acm.org \
--cc=chensong_2000@189.cn \
--cc=dan.carpenter@oracle.com \
--cc=david.kershner@unisys.com \
--cc=fmdefrancesco@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jgross@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).