From: Avri Altman <Avri.Altman@wdc.com>
To: Can Guo <cang@codeaurora.org>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
"hongwus@codeaurora.org" <hongwus@codeaurora.org>,
"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
"sh425.lee@samsung.com" <sh425.lee@samsung.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"saravanak@google.com" <saravanak@google.com>,
"salyzyn@google.com" <salyzyn@google.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v6 2/8] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config
Date: Mon, 27 Jul 2020 12:52:10 +0000 [thread overview]
Message-ID: <SN6PR04MB4640AF17D6CE3BF597528112FC720@SN6PR04MB4640.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1595504787-19429-3-git-send-email-cang@codeaurora.org>
>
> If ufs_qcom_dump_dbg_regs() calls ufs_qcom_testbus_config() from
> ufshcd_suspend/resume and/or clk gate/ungate context,
> pm_runtime_get_sync()
> and ufshcd_hold() will cause racing problems. Fix this by removing the
> unnecessary calls of pm_runtime_get_sync() and ufshcd_hold().
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Reviewed-by: Hongwu Su <hongwus@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
next prev parent reply other threads:[~2020-07-27 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 11:46 [PATCH v6 0/8] Fix up and simplify error recovery mechanism Can Guo
2020-07-23 11:46 ` [PATCH v6 1/8] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-07-23 11:46 ` [PATCH v6 2/8] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-07-27 12:52 ` Avri Altman [this message]
2020-07-23 11:46 ` [PATCH v6 3/8] scsi: ufs-qcom: Fix schedule while atomic error in ufs_qcom_dump_dbg_regs Can Guo
2020-07-27 13:05 ` Avri Altman
2020-07-28 2:21 ` Can Guo
2020-07-23 11:46 ` [PATCH v6 4/8] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-07-27 13:12 ` Avri Altman
2020-07-23 11:46 ` [PATCH v6 5/8] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-07-23 11:46 ` [PATCH v6 6/8] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-07-23 11:46 ` [PATCH v6 7/8] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-07-23 11:46 ` [PATCH v6 8/8] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB4640AF17D6CE3BF597528112FC720@SN6PR04MB4640.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).