From: Can Guo <cang@codeaurora.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
hongwus@codeaurora.org, rnayak@codeaurora.org,
sh425.lee@samsung.com, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 3/8] scsi: ufs-qcom: Fix schedule while atomic error in ufs_qcom_dump_dbg_regs
Date: Tue, 28 Jul 2020 10:21:38 +0800 [thread overview]
Message-ID: <e828fd80f3fe9d0f64a5629eebd5a345@codeaurora.org> (raw)
In-Reply-To: <SN6PR04MB4640F4CEAB7F5FFA51648B6CFC720@SN6PR04MB4640.namprd04.prod.outlook.com>
Hi Avri,
On 2020-07-27 21:05, Avri Altman wrote:
>> Dumping testbus registers needs to sleep a bit intermittently as there
>> are
>> too many of them. Skip them for those contexts where sleep is not
>> allowed.
>>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> ---
>> drivers/scsi/ufs/ufs-qcom.c | 15 +++++++++------
>> 1 file changed, 9 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
>> index 7da27ee..7831b2b 100644
>> --- a/drivers/scsi/ufs/ufs-qcom.c
>> +++ b/drivers/scsi/ufs/ufs-qcom.c
>> @@ -1651,13 +1651,16 @@ static void ufs_qcom_dump_dbg_regs(struct
>> ufs_hba *hba)
>> ufshcd_dump_regs(hba, REG_UFS_SYS1CLK_1US, 16 * 4,
>> "HCI Vendor Specific Registers ");
>>
>> - /* sleep a bit intermittently as we are dumping too much data
>> */
>> ufs_qcom_print_hw_debug_reg_all(hba, NULL,
>> ufs_qcom_dump_regs_wrapper);
>> - udelay(1000);
>> - ufs_qcom_testbus_read(hba);
>> - udelay(1000);
>> - ufs_qcom_print_unipro_testbus(hba);
>> - udelay(1000);
>> +
>> + if (in_task()) {
>> + /* sleep a bit intermittently as we are dumping too
>> much data */
>> + usleep_range(1000, 1100);
>> + ufs_qcom_testbus_read(hba);
>> + usleep_range(1000, 1100);
>> + ufs_qcom_print_unipro_testbus(hba);
>> + usleep_range(1000, 1100);
>> + }
>> }
> How about moving the intermittent sleep out of the check if preemption
> is disabled?
> And maybe then you need to switch back to uedlay?
I will just remove all the testbus prints in next version to save us
time here.
Thanks,
Can Guo.
next prev parent reply other threads:[~2020-07-28 2:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 11:46 [PATCH v6 0/8] Fix up and simplify error recovery mechanism Can Guo
2020-07-23 11:46 ` [PATCH v6 1/8] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-07-23 11:46 ` [PATCH v6 2/8] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-07-27 12:52 ` Avri Altman
2020-07-23 11:46 ` [PATCH v6 3/8] scsi: ufs-qcom: Fix schedule while atomic error in ufs_qcom_dump_dbg_regs Can Guo
2020-07-27 13:05 ` Avri Altman
2020-07-28 2:21 ` Can Guo [this message]
2020-07-23 11:46 ` [PATCH v6 4/8] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-07-27 13:12 ` Avri Altman
2020-07-23 11:46 ` [PATCH v6 5/8] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-07-23 11:46 ` [PATCH v6 6/8] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-07-23 11:46 ` [PATCH v6 7/8] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-07-23 11:46 ` [PATCH v6 8/8] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e828fd80f3fe9d0f64a5629eebd5a345@codeaurora.org \
--to=cang@codeaurora.org \
--cc=Avri.Altman@wdc.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).