From: kernel test robot <lkp@intel.com> To: Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>, linux-sctp@vger.kernel.org Cc: kbuild-all@lists.01.org, Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>, Neil Horman <nhorman@tuxdriver.com>, Michael Tuexen <tuexen@fh-muenster.de>, davem@davemloft.net Subject: Re: [PATCHv2 net-next 15/17] sctp: add the error cause for new encapsulation port restart Date: Thu, 08 Oct 2020 14:33:06 +0000 [thread overview] Message-ID: <202010082237.zpvcVDj7-lkp@intel.com> (raw) In-Reply-To: <8815067eea44ffd7274b0038e48c2618c2e77916.1602150362.git.lucien.xin@gmail.com> [-- Attachment #1: Type: text/plain, Size: 4088 bytes --] Hi Xin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9faebeb2d80065926dfbc09cb73b1bb7779a89cd config: i386-randconfig-s002-20201008 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-218-gc0e96d6d-dirty # https://github.com/0day-ci/linux/commit/9119d2be86deb6950b26b152a51ddad0a95182a5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211 git checkout 9119d2be86deb6950b26b152a51ddad0a95182a5 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> echo echo "sparse warnings: (new ones prefixed by >>)" echo net/sctp/sm_make_chunk.c: note: in included file (through include/net/sctp/sctp.h): include/net/sctp/structs.h:334:41: sparse: sparse: array of flexible structures >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: cast from restricted __be16 >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] val @@ got restricted __be16 [usertype] encap_port @@ >> net/sctp/sm_make_chunk.c:1157:24: sparse: expected unsigned short [usertype] val >> net/sctp/sm_make_chunk.c:1157:24: sparse: got restricted __be16 [usertype] encap_port >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: cast from restricted __be16 >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] val @@ got restricted __be16 [usertype] encap_port @@ net/sctp/sm_make_chunk.c:1158:24: sparse: expected unsigned short [usertype] val net/sctp/sm_make_chunk.c:1158:24: sparse: got restricted __be16 [usertype] encap_port net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:3081:48: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected int optname @@ got restricted __be16 @@ net/sctp/sm_make_chunk.c:3081:48: sparse: expected int optname net/sctp/sm_make_chunk.c:3081:48: sparse: got restricted __be16 net/sctp/sm_make_chunk.c:3153:48: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected int optname @@ got restricted __be16 @@ net/sctp/sm_make_chunk.c:3153:48: sparse: expected int optname net/sctp/sm_make_chunk.c:3153:48: sparse: got restricted __be16 vim +1157 net/sctp/sm_make_chunk.c 1144 1145 struct sctp_chunk *sctp_make_new_encap_port(const struct sctp_association *asoc, 1146 const struct sctp_chunk *chunk) 1147 { 1148 struct sctp_new_encap_port_hdr nep; 1149 struct sctp_chunk *retval; 1150 1151 retval = sctp_make_abort(asoc, chunk, 1152 sizeof(struct sctp_errhdr) + sizeof(nep)); 1153 if (!retval) 1154 goto nodata; 1155 1156 sctp_init_cause(retval, SCTP_ERROR_NEW_ENCAP_PORT, sizeof(nep)); > 1157 nep.cur_port = htons(SCTP_INPUT_CB(chunk->skb)->encap_port); 1158 nep.new_port = htons(chunk->transport->encap_port); 1159 sctp_addto_chunk(retval, sizeof(nep), &nep); 1160 1161 nodata: 1162 return retval; 1163 } 1164 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 30577 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>, linux-sctp@vger.kernel.org Cc: kbuild-all@lists.01.org, Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>, Neil Horman <nhorman@tuxdriver.com>, Michael Tuexen <tuexen@fh-muenster.de>, davem@davemloft.net Subject: Re: [PATCHv2 net-next 15/17] sctp: add the error cause for new encapsulation port restart Date: Thu, 8 Oct 2020 22:33:06 +0800 [thread overview] Message-ID: <202010082237.zpvcVDj7-lkp@intel.com> (raw) Message-ID: <20201008143306.J4dsX2yIiHfVQt2QYYBvmEQoW1g-XqSDVx-Ozw4mrqY@z> (raw) In-Reply-To: <8815067eea44ffd7274b0038e48c2618c2e77916.1602150362.git.lucien.xin@gmail.com> [-- Attachment #1: Type: text/plain, Size: 4088 bytes --] Hi Xin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9faebeb2d80065926dfbc09cb73b1bb7779a89cd config: i386-randconfig-s002-20201008 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-218-gc0e96d6d-dirty # https://github.com/0day-ci/linux/commit/9119d2be86deb6950b26b152a51ddad0a95182a5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211 git checkout 9119d2be86deb6950b26b152a51ddad0a95182a5 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> echo echo "sparse warnings: (new ones prefixed by >>)" echo net/sctp/sm_make_chunk.c: note: in included file (through include/net/sctp/sctp.h): include/net/sctp/structs.h:334:41: sparse: sparse: array of flexible structures >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: cast from restricted __be16 >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] val @@ got restricted __be16 [usertype] encap_port @@ >> net/sctp/sm_make_chunk.c:1157:24: sparse: expected unsigned short [usertype] val >> net/sctp/sm_make_chunk.c:1157:24: sparse: got restricted __be16 [usertype] encap_port >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: cast from restricted __be16 >> net/sctp/sm_make_chunk.c:1157:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] val @@ got restricted __be16 [usertype] encap_port @@ net/sctp/sm_make_chunk.c:1158:24: sparse: expected unsigned short [usertype] val net/sctp/sm_make_chunk.c:1158:24: sparse: got restricted __be16 [usertype] encap_port net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:1158:24: sparse: sparse: cast from restricted __be16 net/sctp/sm_make_chunk.c:3081:48: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected int optname @@ got restricted __be16 @@ net/sctp/sm_make_chunk.c:3081:48: sparse: expected int optname net/sctp/sm_make_chunk.c:3081:48: sparse: got restricted __be16 net/sctp/sm_make_chunk.c:3153:48: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected int optname @@ got restricted __be16 @@ net/sctp/sm_make_chunk.c:3153:48: sparse: expected int optname net/sctp/sm_make_chunk.c:3153:48: sparse: got restricted __be16 vim +1157 net/sctp/sm_make_chunk.c 1144 1145 struct sctp_chunk *sctp_make_new_encap_port(const struct sctp_association *asoc, 1146 const struct sctp_chunk *chunk) 1147 { 1148 struct sctp_new_encap_port_hdr nep; 1149 struct sctp_chunk *retval; 1150 1151 retval = sctp_make_abort(asoc, chunk, 1152 sizeof(struct sctp_errhdr) + sizeof(nep)); 1153 if (!retval) 1154 goto nodata; 1155 1156 sctp_init_cause(retval, SCTP_ERROR_NEW_ENCAP_PORT, sizeof(nep)); > 1157 nep.cur_port = htons(SCTP_INPUT_CB(chunk->skb)->encap_port); 1158 nep.new_port = htons(chunk->transport->encap_port); 1159 sctp_addto_chunk(retval, sizeof(nep), &nep); 1160 1161 nodata: 1162 return retval; 1163 } 1164 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 30577 bytes --]
next prev parent reply other threads:[~2020-10-08 14:33 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-08 9:47 [PATCHv2 net-next 00/17] sctp: Implement RFC6951: UDP Encapsulation of SCTP Xin Long 2020-10-08 9:47 ` Xin Long 2020-10-08 9:47 ` [PATCHv2 net-next 01/17] udp: check udp sock encap_type in __udp_lib_err Xin Long 2020-10-08 9:47 ` Xin Long 2020-10-08 9:47 ` [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing Xin Long 2020-10-08 9:47 ` Xin Long 2020-10-08 9:47 ` [PATCHv2 net-next 03/17] udp: do checksum properly in skb_udp_tunnel_segment Xin Long 2020-10-08 9:47 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 04/17] udp: support sctp over udp " Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 05/17] sctp: create udp4 sock and add its encap_rcv Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 06/17] sctp: create udp6 sock and set " Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 07/17] sctp: add encap_err_lookup for udp encap socks Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 08/17] sctp: add encap_port for netns sock asoc and transport Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 09/17] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 10/17] sctp: allow changing transport encap_port by peer packets Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 11/17] sctp: add udphdr to overhead when udp_port is set Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 12/17] sctp: call sk_setup_caps in sctp_packet_transmit instead Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 13/17] sctp: support for sending packet over udp4 sock Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 14/17] sctp: support for sending packet over udp6 sock Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 15/17] sctp: add the error cause for new encapsulation port restart Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 16/17] sctp: handle the init chunk matching an existing asoc Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 9:48 ` [PATCHv2 net-next 17/17] sctp: enable udp tunneling socks Xin Long 2020-10-08 9:48 ` Xin Long 2020-10-08 15:46 ` kernel test robot 2020-10-08 15:46 ` kernel test robot 2020-10-09 2:02 ` Xin Long 2020-10-09 2:02 ` Xin Long 2020-10-08 14:33 ` kernel test robot [this message] 2020-10-08 14:33 ` [PATCHv2 net-next 15/17] sctp: add the error cause for new encapsulation port restart kernel test robot 2020-10-08 13:10 ` [PATCHv2 net-next 09/17] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt kernel test robot 2020-10-08 13:10 ` kernel test robot 2020-10-08 21:18 ` [PATCHv2 net-next 06/17] sctp: create udp6 sock and set its encap_rcv kernel test robot 2020-10-08 21:18 ` kernel test robot 2020-10-09 1:59 ` Xin Long 2020-10-09 1:59 ` Xin Long 2020-10-08 18:29 ` [PATCHv2 net-next 05/17] sctp: create udp4 sock and add " kernel test robot 2020-10-08 18:29 ` kernel test robot 2020-10-09 1:59 ` Xin Long 2020-10-09 1:59 ` Xin Long 2020-10-08 10:01 ` [PATCHv2 net-next 04/17] udp: support sctp over udp in skb_udp_tunnel_segment Xin Long 2020-10-08 10:01 ` Xin Long 2020-10-08 10:01 ` [PATCHv2 net-next 03/17] udp: do checksum properly " Xin Long 2020-10-08 10:01 ` Xin Long 2020-10-08 12:44 ` [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing Willem de Bruijn 2020-10-08 12:44 ` Willem de Bruijn 2020-10-09 1:48 ` Xin Long 2020-10-09 1:48 ` Xin Long 2020-10-09 13:59 ` Willem de Bruijn 2020-10-09 13:59 ` Willem de Bruijn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202010082237.zpvcVDj7-lkp@intel.com \ --to=lkp@intel.com \ --cc=davem@davemloft.net \ --cc=kbuild-all@lists.01.org \ --cc=linux-sctp@vger.kernel.org \ --cc=lucien.xin@gmail.com \ --cc=marcelo.leitner@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=nhorman@tuxdriver.com \ --cc=tuexen@fh-muenster.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).