From: Michael Tuexen <tuexen@fh-muenster.de> To: David Laight <David.Laight@ACULAB.COM> Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>, Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>, "linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>, Neil Horman <nhorman@tuxdriver.com>, "davem@davemloft.net" <davem@davemloft.net>, "gnault@redhat.com" <gnault@redhat.com>, "pabeni@redhat.com" <pabeni@redhat.com>, "willemdebruijn.kernel@gmail.com" <willemdebruijn.kernel@gmail.com> Subject: Re: [PATCHv3 net-next 16/16] sctp: enable udp tunneling socks Date: Thu, 15 Oct 2020 21:35:28 +0000 [thread overview] Message-ID: <2EF3C673-B68F-4CA8-928E-07B72586434F@fh-muenster.de> (raw) In-Reply-To: <a5ee7f3c99b14e43aac8938434fd9264@AcuMS.aculab.com> [-- Attachment #1: Type: text/plain, Size: 1043 bytes --] > On 15. Oct 2020, at 23:23, David Laight <David.Laight@ACULAB.COM> wrote: > > From: Marcelo Ricardo Leitner >> Sent: 15 October 2020 18:43 >> >> Actually.. >> >> On Tue, Oct 13, 2020 at 03:27:41PM +0800, Xin Long wrote: >> ... >>> Also add sysctl udp_port to allow changing the listening >>> sock's port by users. > > I've not read through this change... > > But surely the UDP port (or ports) that you need to use > will depend on the remote system's configuration. The local encapsulation port can be system wide, the remote encapsulation port is per remote address. See https://tools.ietf.org/html/rfc6951#section-5.1 Best regards Michael > > So they need to be a property of the socket, not a > system-wide value. > > I can easily imagine my M3UA code connecting to different > network providers which have decided to use different > UDP port numbers. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 5257 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tuexen <tuexen@fh-muenster.de> To: David Laight <David.Laight@ACULAB.COM> Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>, Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>, "linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>, Neil Horman <nhorman@tuxdriver.com>, "davem@davemloft.net" <davem@davemloft.net>, "gnault@redhat.com" <gnault@redhat.com>, "pabeni@redhat.com" <pabeni@redhat.com>, "willemdebruijn.kernel@gmail.com" <willemdebruijn.kernel@gmail.com> Subject: Re: [PATCHv3 net-next 16/16] sctp: enable udp tunneling socks Date: Thu, 15 Oct 2020 23:35:28 +0200 [thread overview] Message-ID: <2EF3C673-B68F-4CA8-928E-07B72586434F@fh-muenster.de> (raw) Message-ID: <20201015213528.YQoCRhdWZfji5s28b16xgU1vaucV62-pVsaBSYh6j8U@z> (raw) In-Reply-To: <a5ee7f3c99b14e43aac8938434fd9264@AcuMS.aculab.com> [-- Attachment #1: Type: text/plain, Size: 1043 bytes --] > On 15. Oct 2020, at 23:23, David Laight <David.Laight@ACULAB.COM> wrote: > > From: Marcelo Ricardo Leitner >> Sent: 15 October 2020 18:43 >> >> Actually.. >> >> On Tue, Oct 13, 2020 at 03:27:41PM +0800, Xin Long wrote: >> ... >>> Also add sysctl udp_port to allow changing the listening >>> sock's port by users. > > I've not read through this change... > > But surely the UDP port (or ports) that you need to use > will depend on the remote system's configuration. The local encapsulation port can be system wide, the remote encapsulation port is per remote address. See https://tools.ietf.org/html/rfc6951#section-5.1 Best regards Michael > > So they need to be a property of the socket, not a > system-wide value. > > I can easily imagine my M3UA code connecting to different > network providers which have decided to use different > UDP port numbers. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 5257 bytes --]
next prev parent reply other threads:[~2020-10-15 21:35 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-13 7:27 [PATCHv3 net-next 00/16] sctp: Implement RFC6951: UDP Encapsulation of SCTP Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 01/16] udp: check udp sock encap_type in __udp_lib_err Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 02/16] udp6: move the mss check after udp gso tunnel processing Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 03/16] udp: support sctp over udp in skb_udp_tunnel_segment Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 04/16] sctp: create udp4 sock and add its encap_rcv Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 05/16] sctp: create udp6 sock and set " Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 06/16] sctp: add encap_err_lookup for udp encap socks Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 07/16] sctp: add encap_port for netns sock asoc and transport Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 08/16] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 09/16] sctp: allow changing transport encap_port by peer packets Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 10/16] sctp: add udphdr to overhead when udp_port is set Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 11/16] sctp: call sk_setup_caps in sctp_packet_transmit instead Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 12/16] sctp: support for sending packet over udp4 sock Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 13/16] sctp: support for sending packet over udp6 sock Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 14/16] sctp: add the error cause for new encapsulation port restart Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 15/16] sctp: handle the init chunk matching an existing asoc Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-13 7:27 ` [PATCHv3 net-next 16/16] sctp: enable udp tunneling socks Xin Long 2020-10-13 7:27 ` Xin Long 2020-10-15 17:42 ` Marcelo Ricardo Leitner 2020-10-15 17:42 ` Marcelo Ricardo Leitner 2020-10-15 21:23 ` David Laight 2020-10-15 21:35 ` Michael Tuexen [this message] 2020-10-15 21:35 ` Michael Tuexen 2020-10-16 7:08 ` Xin Long 2020-10-16 7:08 ` Xin Long 2020-10-19 10:40 ` Xin Long 2020-10-19 10:40 ` Xin Long 2020-10-13 17:19 ` [PATCHv3 net-next 02/16] udp6: move the mss check after udp gso tunnel processing Willem de Bruijn 2020-10-13 17:19 ` Willem de Bruijn 2020-10-15 3:34 ` [PATCHv3 net-next 00/16] sctp: Implement RFC6951: UDP Encapsulation of SCTP Jakub Kicinski 2020-10-15 3:34 ` Jakub Kicinski 2020-10-15 12:41 ` Marcelo Ricardo Leitner 2020-10-15 12:41 ` Marcelo Ricardo Leitner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2EF3C673-B68F-4CA8-928E-07B72586434F@fh-muenster.de \ --to=tuexen@fh-muenster.de \ --cc=David.Laight@ACULAB.COM \ --cc=davem@davemloft.net \ --cc=gnault@redhat.com \ --cc=linux-sctp@vger.kernel.org \ --cc=lucien.xin@gmail.com \ --cc=marcelo.leitner@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=nhorman@tuxdriver.com \ --cc=pabeni@redhat.com \ --cc=willemdebruijn.kernel@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).