linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] bindings: serial: Add xilinx compatible
@ 2020-08-19 16:42 Shubhrajyoti Datta
  0 siblings, 0 replies; 3+ messages in thread
From: Shubhrajyoti Datta @ 2020-08-19 16:42 UTC (permalink / raw)
  To: linux-serial; +Cc: devicetree, jslaby, robh+dt, gregkh, Shubhrajyoti Datta

Add the arm,xlnx-sbsa-uart compatible.
Xilinx versal uart is similar to sbsa-uart except that it has
termios configurable.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
 Documentation/devicetree/bindings/serial/pl011.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
index c23c93b..6e123b1 100644
--- a/Documentation/devicetree/bindings/serial/pl011.yaml
+++ b/Documentation/devicetree/bindings/serial/pl011.yaml
@@ -20,6 +20,7 @@ select:
         enum:
           - arm,pl011
           - zte,zx296702-uart
+          - arm,xlnx-sbsa-uart
   required:
     - compatible
 
@@ -32,6 +33,7 @@ properties:
       - items:
           - const: zte,zx296702-uart
           - const: arm,primecell
+          - const: arm,xlnx-sbsa-uart
 
   reg:
     maxItems: 1
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] bindings: serial: Add xilinx compatible
  2020-08-19 16:43 Shubhrajyoti Datta
@ 2020-08-25 22:12 ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-08-25 22:12 UTC (permalink / raw)
  To: Shubhrajyoti Datta; +Cc: linux-serial, devicetree, jslaby, git-dev, gregkh

On Wed, Aug 19, 2020 at 10:13:58PM +0530, Shubhrajyoti Datta wrote:
> Add the arm,xlnx-sbsa-uart compatible.
> Xilinx versal uart is similar to sbsa-uart except that it has
> termios configurable.

Yet still not just a pl011? Sigh.

> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
>  Documentation/devicetree/bindings/serial/pl011.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
> index c23c93b..6e123b1 100644
> --- a/Documentation/devicetree/bindings/serial/pl011.yaml
> +++ b/Documentation/devicetree/bindings/serial/pl011.yaml
> @@ -20,6 +20,7 @@ select:
>          enum:
>            - arm,pl011
>            - zte,zx296702-uart
> +          - arm,xlnx-sbsa-uart
>    required:
>      - compatible
>  
> @@ -32,6 +33,7 @@ properties:
>        - items:
>            - const: zte,zx296702-uart
>            - const: arm,primecell
> +          - const: arm,xlnx-sbsa-uart

You are defining compatible must be:

compatible = "zte,zx296702-uart", "arm,primecell", "arm,xlnx-sbsa-uart";

Probably not what you want. And breaks ZTE.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] bindings: serial: Add xilinx compatible
@ 2020-08-19 16:43 Shubhrajyoti Datta
  2020-08-25 22:12 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Shubhrajyoti Datta @ 2020-08-19 16:43 UTC (permalink / raw)
  To: linux-serial
  Cc: devicetree, jslaby, robh+dt, git-dev, gregkh, Shubhrajyoti Datta

Add the arm,xlnx-sbsa-uart compatible.
Xilinx versal uart is similar to sbsa-uart except that it has
termios configurable.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
 Documentation/devicetree/bindings/serial/pl011.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
index c23c93b..6e123b1 100644
--- a/Documentation/devicetree/bindings/serial/pl011.yaml
+++ b/Documentation/devicetree/bindings/serial/pl011.yaml
@@ -20,6 +20,7 @@ select:
         enum:
           - arm,pl011
           - zte,zx296702-uart
+          - arm,xlnx-sbsa-uart
   required:
     - compatible
 
@@ -32,6 +33,7 @@ properties:
       - items:
           - const: zte,zx296702-uart
           - const: arm,primecell
+          - const: arm,xlnx-sbsa-uart
 
   reg:
     maxItems: 1
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-25 22:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 16:42 [PATCH 1/2] bindings: serial: Add xilinx compatible Shubhrajyoti Datta
2020-08-19 16:43 Shubhrajyoti Datta
2020-08-25 22:12 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).