From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pascal Terjan <pterjan@gmail.com>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org,
Pascal Terjan <pterjan@google.com>
Subject: Re: [PATCH] Remove every trace of SERIAL_MAGIC
Date: Fri, 4 Oct 2019 14:45:05 +0200 [thread overview]
Message-ID: <20191004124505.GA556034@kroah.com> (raw)
In-Reply-To: <20190927205524.250238-1-pterjan@google.com>
On Fri, Sep 27, 2019 at 10:55:24PM +0200, Pascal Terjan wrote:
> The only code mentioning it doesn't build (and hasn't at least since git)
> and doesn't include the header defining it.
>
> This means removing support for checking magic in amiserial.c
> (SERIAL_PARANOIA_CHECK option), which was checking a magic field which
> doesn't currently exist in the struct.
> ---
> Documentation/process/magic-number.rst | 1 -
> .../it_IT/process/magic-number.rst | 1 -
> .../zh_CN/process/magic-number.rst | 1 -
> drivers/net/wan/z85230.h | 2 -
> drivers/tty/amiserial.c | 81 +------------------
> 5 files changed, 1 insertion(+), 85 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch does not have a Signed-off-by: line. Please read the
kernel file, Documentation/SubmittingPatches and resend it after
adding that line. Note, the line needs to be in the body of the
email, before the patch, not at the bottom of the patch or in the
email signature.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2019-10-04 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 20:55 [PATCH] Remove every trace of SERIAL_MAGIC Pascal Terjan
2019-10-04 12:45 ` Greg Kroah-Hartman [this message]
2019-10-04 13:20 ` Pascal Terjan
2019-10-04 13:22 ` Greg Kroah-Hartman
2019-11-04 19:35 ` [PATCH v3] " Pascal Terjan
2019-11-05 8:42 ` Geert Uytterhoeven
2019-11-05 19:27 ` [PATCH v4] " Pascal Terjan
2019-10-04 13:29 ` [PATCH] " John Paul Adrian Glaubitz
[not found] ` <CAANdO=LB1=i6qKt+J6yBXg9EaPJ66yZ_bkd96hftKkcR0Ee06w@mail.gmail.com>
2019-10-04 13:36 ` John Paul Adrian Glaubitz
2019-10-04 13:37 ` Pascal Terjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004124505.GA556034@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
--cc=pterjan@gmail.com \
--cc=pterjan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).