From: Pascal Terjan <pterjan@google.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH] Remove every trace of SERIAL_MAGIC
Date: Fri, 4 Oct 2019 14:37:28 +0100 [thread overview]
Message-ID: <CAANdO=Km1Jbog8v5f2wunzjVpTdHH6ttkZWEw9s7=07PNto4-Q@mail.gmail.com> (raw)
In-Reply-To: <e1b5cbbe-e44a-7119-286f-79c1fec08e1f@physik.fu-berlin.de>
[ Sorry, for previous HTML email, trying to send patches from work
machine for the first time, re-sending in text ]
On Fri, 4 Oct 2019 at 14:29, John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> On 10/4/19 3:20 PM, Pascal Terjan wrote:
> > The only code mentioning it doesn't build (and hasn't at least since git)
> > and doesn't include the header defining it.
> What do you mean, amiserial doesn't build?
The code doesn't build if enabling the "option" SERIAL_PARANOIA_CHECK
in the file, this patch is removing that option and he code protected
by it
> root@elgar:~> grep AMIGA_BUILTIN_SERIAL /boot/config-$(uname -r)
> CONFIG_AMIGA_BUILTIN_SERIAL=y
> root@elgar:~>
>
> root@elgar:~> uname -a
> Linux elgar 5.2.0-2-m68k #1 Debian 5.2.9-2 (2019-08-21) m68k GNU/Linux
> root@elgar:~>
>
> We're using this driver, it works just fine.
>
> And I'm not sure what SERIAL_MAGIC does. Is that for CONFIG_MAGIC_SYSRQ_SERIAL?
It used to be a magic number in the struct to verify you are getting
the expected object
> Because we still use that, too. Although I haven't tested it for a while but
> I'm using the serial console on my Amiga 4000 right now using amiserial.c.
>
prev parent reply other threads:[~2019-10-04 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 20:55 [PATCH] Remove every trace of SERIAL_MAGIC Pascal Terjan
2019-10-04 12:45 ` Greg Kroah-Hartman
2019-10-04 13:20 ` Pascal Terjan
2019-10-04 13:22 ` Greg Kroah-Hartman
2019-11-04 19:35 ` [PATCH v3] " Pascal Terjan
2019-11-05 8:42 ` Geert Uytterhoeven
2019-11-05 19:27 ` [PATCH v4] " Pascal Terjan
2019-10-04 13:29 ` [PATCH] " John Paul Adrian Glaubitz
[not found] ` <CAANdO=LB1=i6qKt+J6yBXg9EaPJ66yZ_bkd96hftKkcR0Ee06w@mail.gmail.com>
2019-10-04 13:36 ` John Paul Adrian Glaubitz
2019-10-04 13:37 ` Pascal Terjan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAANdO=Km1Jbog8v5f2wunzjVpTdHH6ttkZWEw9s7=07PNto4-Q@mail.gmail.com' \
--to=pterjan@google.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).