From: Sergey Organov <sorganov@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Fabio Estevam" <festevam@gmail.com>,
linux-serial@vger.kernel.org, "Jiri Slaby" <jirislaby@kernel.org>,
"Tomasz Moń" <tomasz.mon@camlingroup.com>,
k.drobinski@camlintechnologies.com,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: Re: [PATCH] serial: imx: reduce RX interrupt frequency
Date: Wed, 05 Jan 2022 16:37:22 +0300 [thread overview]
Message-ID: <87pmp64831.fsf@osv.gnss.ru> (raw)
In-Reply-To: <20220105130431.b3vb2icesuedaavk@pengutronix.de> (Marc Kleine-Budde's message of "Wed, 5 Jan 2022 14:04:31 +0100")
Marc Kleine-Budde <mkl@pengutronix.de> writes:
> On 05.01.2022 16:00:34, Sergey Organov wrote:
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>>
>> > On Tue, Jan 04, 2022 at 11:32:03AM +0100, Tomasz Moń wrote:
>> >> Triggering RX interrupt for every byte defeats the purpose of aging
>> >> timer and leads to interrupt starvation at high baud rates.
>> >>
>> >> Increase receiver trigger level to 8 to increase the minimum period
>> >> between RX interrupts to 8 characters time. The tradeoff is increased
>> >> latency. In the worst case scenario, where RX data has intercharacter
>> >> delay slightly less than aging timer (8 characters time), it can take
>> >> up to 63 characters time for the interrupt to be raised since the
>> >> reception of the first character.
>> >
>> > Why can't you do this dynamically based on the baud rate so as to always
>> > work properly for all speeds without increased delays for slower ones?
>>
>> I don't like the idea of dynamic threshold as I don't think increased
>> complexity is worth it.
>>
>> In fact the threshold works "properly" on any baud rate, as maximum
>> latency is proportional to the current baud rate, and if somebody does
>> care about *absolute* latency, increasing baud rate is the primary
>> solution.
>
> Nope - this only works if you have both sides under control.... Which is
> not the case in our $CUSTROMER's use case.
Yep, if one can't use primary solution, they need to come up with
something else. Where is that historical "low-latency" bit, by the way?
Thanks,
-- Sergey Organov
next prev parent reply other threads:[~2022-01-05 13:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 10:32 [PATCH] serial: imx: reduce RX interrupt frequency Tomasz Moń
2022-01-04 10:43 ` Ahmad Fatoum
2022-01-04 11:05 ` Tomasz Moń
2022-01-04 10:54 ` Greg Kroah-Hartman
2022-01-04 11:13 ` Tomasz Moń
2022-01-04 11:38 ` Greg Kroah-Hartman
2022-01-04 22:49 ` Uwe Kleine-König
2022-01-05 7:59 ` Tomasz Moń
2022-01-05 10:37 ` Greg Kroah-Hartman
2022-01-05 10:56 ` Tomasz Moń
2022-01-05 10:57 ` Marc Kleine-Budde
2022-01-06 15:39 ` Sergey Organov
2022-01-05 13:34 ` Sergey Organov
2022-01-06 15:05 ` Uwe Kleine-König
2022-01-10 6:14 ` Tomasz Moń
2022-01-10 8:31 ` Uwe Kleine-König
2022-01-05 13:00 ` Sergey Organov
2022-01-05 13:04 ` Marc Kleine-Budde
2022-01-05 13:37 ` Sergey Organov [this message]
2022-01-05 13:40 ` Marc Kleine-Budde
2022-01-05 14:37 ` Sergey Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmp64831.fsf@osv.gnss.ru \
--to=sorganov@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=k.drobinski@camlintechnologies.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-serial@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).