From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 4/5 v3] sh: define __BIG_ENDIAN for math-emu
Date: Mon, 4 Oct 2021 17:19:13 -0700 [thread overview]
Message-ID: <20211005001914.28574-5-rdunlap@infradead.org> (raw)
In-Reply-To: <20211005001914.28574-1-rdunlap@infradead.org>
Fix this by defining both ENDIAN macros in
<asm/sfp-machine.h> so that they can be utilized in
<math-emu/soft-fp.h> according to the latter's comment:
/* Allow sfp-machine to have its own byte order definitions. */
(This is what is done in arch/nds32/include/asm/sfp-machine.h.)
This placates these build warnings:
In file included from ../arch/sh/math-emu/math.c:23:
../include/math-emu/single.h:50:21: warning: "__BIG_ENDIAN" is not defined, evaluates to 0 [-Wundef]
50 | #if __BYTE_ORDER == __BIG_ENDIAN
In file included from ../arch/sh/math-emu/math.c:24:
../include/math-emu/double.h:59:21: warning: "__BIG_ENDIAN" is not defined, evaluates to 0 [-Wundef]
59 | #if __BYTE_ORDER == __BIG_ENDIAN
Fixes: 4b565680d163 ("sh: math-emu support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
v2: use same preprocessor method that nds32 does;
add Geert's Reviewed-by;
renumber patches;
add more Cc's;
v3: renumber, rebase, and resend;
add Tested-by: JPAG;
arch/sh/include/asm/sfp-machine.h | 8 ++++++++
1 file changed, 8 insertions(+)
--- linux-next-20211001.orig/arch/sh/include/asm/sfp-machine.h
+++ linux-next-20211001/arch/sh/include/asm/sfp-machine.h
@@ -13,6 +13,14 @@
#ifndef _SFP_MACHINE_H
#define _SFP_MACHINE_H
+#ifdef __BIG_ENDIAN__
+#define __BYTE_ORDER __BIG_ENDIAN
+#define __LITTLE_ENDIAN 0
+#else
+#define __BYTE_ORDER __LITTLE_ENDIAN
+#define __BIG_ENDIAN 0
+#endif
+
#define _FP_W_TYPE_SIZE 32
#define _FP_W_TYPE unsigned long
#define _FP_WS_TYPE signed long
next prev parent reply other threads:[~2021-10-05 0:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 0:19 [PATCH 0/5 v3] sh: fixes for various build and kconfig warnings Randy Dunlap
2021-10-05 0:19 ` [PATCH 1/5 v3] sh: fix kconfig unmet dependency warning for FRAME_POINTER Randy Dunlap
2021-10-05 0:19 ` [PATCH 2/5 v3] sh: add git tree to MAINTAINERS Randy Dunlap
2021-10-05 7:21 ` Geert Uytterhoeven
2021-10-27 20:54 ` Rich Felker
2021-10-28 8:33 ` Geert Uytterhoeven
2021-10-28 13:30 ` Rich Felker
2021-10-28 13:37 ` Geert Uytterhoeven
2021-11-01 19:10 ` Konstantin Ryabitsev
2021-10-05 0:19 ` [PATCH 3/5 v3] sh: math-emu: drop unused functions Randy Dunlap
2021-10-05 7:26 ` Geert Uytterhoeven
2021-10-06 1:06 ` Randy Dunlap
2021-10-05 0:19 ` Randy Dunlap [this message]
2021-10-05 0:19 ` [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings Randy Dunlap
2021-10-08 18:39 ` Rob Landley
2021-10-08 19:46 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005001914.28574-5-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).