From: Randy Dunlap <rdunlap@infradead.org>
To: Rob Landley <rob@landley.net>, linux-kernel@vger.kernel.org
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Subject: Re: [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings
Date: Fri, 8 Oct 2021 12:46:53 -0700 [thread overview]
Message-ID: <754abc70-d539-296a-8993-3a66656e44b1@infradead.org> (raw)
In-Reply-To: <1191978c-be37-87b1-bbc9-f0aa128d0961@landley.net>
On 10/8/21 11:39 AM, Rob Landley wrote:
> On 10/4/21 7:19 PM, Randy Dunlap wrote:
>> kernel.h defines READ and WRITE, so rename the SH math-emu macros
>> to MREAD and MWRITE.
>
> This one doesn't apply for me. My file has:
>
> #define WRITE(d,a) ({if(put_user(d, (typeof (d)*)a)) return -EFAULT;})
>
> But your patch tries to remove:
>
> -#define WRITE(d,a) ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})
>
> Which is odd because git log says my tree is current as of today, but git log on
> this file says it was last updated:
>
> commit 2e1661d2673667d886cd40ad9f414cb6db48d8da
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Thu May 23 11:04:24 2019 -0500
>
> What did I miss?
Hi Rob,
I am making patches to linux-next, which contains this:
commit ca42bc4b7bda
Author: Al Viro <viro@zeniv.linux.org.uk>
Date: Thu Dec 31 23:23:01 2020 +0000
sh: fix trivial misannotations
which adds the __user annotations...
--
~Randy
prev parent reply other threads:[~2021-10-08 19:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 0:19 [PATCH 0/5 v3] sh: fixes for various build and kconfig warnings Randy Dunlap
2021-10-05 0:19 ` [PATCH 1/5 v3] sh: fix kconfig unmet dependency warning for FRAME_POINTER Randy Dunlap
2021-10-05 0:19 ` [PATCH 2/5 v3] sh: add git tree to MAINTAINERS Randy Dunlap
2021-10-05 7:21 ` Geert Uytterhoeven
2021-10-27 20:54 ` Rich Felker
2021-10-28 8:33 ` Geert Uytterhoeven
2021-10-28 13:30 ` Rich Felker
2021-10-28 13:37 ` Geert Uytterhoeven
2021-11-01 19:10 ` Konstantin Ryabitsev
2021-10-05 0:19 ` [PATCH 3/5 v3] sh: math-emu: drop unused functions Randy Dunlap
2021-10-05 7:26 ` Geert Uytterhoeven
2021-10-06 1:06 ` Randy Dunlap
2021-10-05 0:19 ` [PATCH 4/5 v3] sh: define __BIG_ENDIAN for math-emu Randy Dunlap
2021-10-05 0:19 ` [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings Randy Dunlap
2021-10-08 18:39 ` Rob Landley
2021-10-08 19:46 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=754abc70-d539-296a-8993-3a66656e44b1@infradead.org \
--to=rdunlap@infradead.org \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rob@landley.net \
--cc=takasi-y@ops.dti.ne.jp \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).