From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: ARC math test regressions (was Re: [PATCH v7 00/13] glibc port to ARC processors)
Date: Thu, 2 Jul 2020 01:00:19 +0000 [thread overview]
Message-ID: <4a04f8dc-c888-1411-0add-8603822d5ee4@synopsys.com> (raw)
In-Reply-To: <e88bc836-ff16-d32b-cc06-fa473c4c6744@synopsys.com>
On 7/1/20 12:13 PM, Vineet Gupta via Libc-alpha wrote:
> On 6/30/20 6:44 PM, Adhemerval Zanella via Libc-alpha wrote:
> FAIL: math/test-float-exp10
> FAIL: math/test-float32-exp10
The exp10 tests needed regen-ulps and now fixed.
> FAIL: math/test-float32x-acos
> FAIL: math/test-float32x-asin
> FAIL: math/test-float64-acos
> FAIL: math/test-float64-asin
> FAIL: math/test-ldouble-acos
> FAIL: math/test-ldouble-asin
This is a regression, as we had no math errors before.
Here's my analysis of the issue so far (I don't have prior builds to corroborate
here).
The failures are following
| Failure: acos (inf): Exception "Invalid operation" not set
| Failure: acos (-inf): Exception "Invalid operation" not set
| Failure: acos (1.125): Exception "Invalid operation" not set
| Failure: acos (-1.125): Exception "Invalid operation" not set
| Failure: acos (max_value): Exception "Invalid operation" not set
| Failure: acos (-max_value): Exception "Invalid operation" not set
...
...
| similarly 6 for each of acos_downward(), acos_towardzero (), acos_upward ()
Simple testcase which confirms that Invalid Exception is *not* being raised
| double in = __builtin_inf ();
| acos(in);
| pass = fetestexcept(FE_INVALID);
Exception *is* raised for @in = __builtin_nans("")
Now acos can come from 2 places depending on LIBM_SVID_COMPAT
- math/w_acos_template.c <-- sets errno only
- math/w_acos_compat.c <-- raises exception FE_INVALID
For ARC, 1st variant is building, so explicit exception is NOT raised.
Is this the issue ?
Or is Invalid Exception supposed to be set by the prologue in acos (both variants)
which looks like following:
__acos (double x)
{
if (__builtin_expect ((__builtin_isgreater(fabs (x), 1.0)), 0))
isgreater() is not unordered so it is not supposed to raise exception unless
signaling so it can't be, and fabs() doesn't seem be doing much except clipping
off some bits.
So I'm confused where the issue is
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-07-02 1:00 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 20:14 [PATCH v7 00/13] glibc port to ARC processors Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 01/13] ARC: ABI Implementation Vineet Gupta
2020-07-01 0:06 ` [PATCH v7.1 " Vineet Gupta
[not found] ` <b6322150-240a-5f06-b700-83e3eb79deec@linaro.org>
2020-07-01 19:36 ` Vineet Gupta
2020-07-01 19:45 ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 02/13] ARC: startup and dynamic linking code Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 03/13] ARC: Thread Local Storage support Vineet Gupta
2020-07-01 0:07 ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 04/13] ARC: Atomics and Locking primitives Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 05/13] ARC: math soft float support Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 06/13] ARC: hardware floating point support Vineet Gupta
2020-07-01 0:08 ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 07/13] ARC: Linux Syscall Interface Vineet Gupta
2020-07-01 0:08 ` [PATCH v7.1 " Vineet Gupta
[not found] ` <e9e2ae28-cd78-5924-c1fa-52b1499c245a@linaro.org>
2020-07-04 3:54 ` Vineet Gupta
2020-07-06 13:20 ` Adhemerval Zanella
2020-07-07 1:25 ` Vineet Gupta
2020-07-07 19:24 ` Adhemerval Zanella
2020-07-07 20:55 ` [PATCH v7.2 " Vineet Gupta
[not found] ` <b64d0df1-4229-d619-0ab1-ded287323775@linaro.org>
2020-07-08 19:32 ` Vineet Gupta
2020-07-09 16:03 ` Adhemerval Zanella
2020-07-09 16:24 ` Vineet Gupta
2020-07-09 16:25 ` Adhemerval Zanella
2020-07-09 21:13 ` Vineet Gupta
2020-07-09 21:36 ` ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface) Vineet Gupta
2020-07-09 22:01 ` Alistair Francis
2020-07-09 22:16 ` Vineet Gupta
2020-07-10 9:28 ` Florian Weimer
2020-07-10 15:53 ` Vineet Gupta
2020-07-10 17:02 ` Florian Weimer
2020-07-10 20:07 ` Vineet Gupta
2020-07-10 20:32 ` Florian Weimer
2020-07-10 19:12 ` Alistair Francis
2020-07-10 20:33 ` Florian Weimer
2020-07-10 20:56 ` Alistair Francis
2020-07-10 19:10 ` Alistair Francis
2020-07-07 21:07 ` [PATCH v7.1 07/13] ARC: Linux Syscall Interface Vineet Gupta
2020-07-07 21:32 ` Joseph Myers
2020-07-07 23:16 ` Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 08/13] ARC: Linux ABI Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 09/13] ARC: Linux Startup and Dynamic Loading Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 10/13] ARC: ABI lists Vineet Gupta
2020-07-01 0:09 ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 11/13] ARC: Build Infrastructure Vineet Gupta
2020-07-03 17:09 ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 12/13] build-many-glibcs.py: Enable ARC builds Vineet Gupta
2020-07-03 17:37 ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 13/13] Documentation for ARC port Vineet Gupta
2020-07-03 17:38 ` Adhemerval Zanella
2020-06-23 16:56 ` [PATCH v7 00/13] glibc port to ARC processors Vineet Gupta
2020-07-01 0:11 ` Vineet Gupta
2020-07-01 1:44 ` Adhemerval Zanella
2020-07-01 19:13 ` Vineet Gupta
2020-07-02 1:00 ` Vineet Gupta [this message]
2020-07-02 7:17 ` ARC math test regressions (was Re: [PATCH v7 00/13] glibc port to ARC processors) Andreas Schwab
2020-07-02 16:27 ` Joseph Myers
2020-07-02 17:45 ` Vineet Gupta
2020-07-02 21:27 ` [PATCH v7 00/13] glibc port to ARC processors Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a04f8dc-c888-1411-0add-8603822d5ee4@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).