From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Florian Weimer <fweimer@redhat.com>,
Vineet Gupta via Libc-alpha <libc-alpha@sourceware.org>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
arcml <linux-snps-arc@lists.infradead.org>
Subject: Re: ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface)
Date: Fri, 10 Jul 2020 20:07:23 +0000 [thread overview]
Message-ID: <ee2187d4-8383-8a8f-29ec-29c4b36007de@synopsys.com> (raw)
In-Reply-To: <87a707z4kr.fsf@oldenburg2.str.redhat.com>
On 7/10/20 10:02 AM, Florian Weimer via Libc-alpha wrote:
> * Vineet Gupta via Libc-alpha:
>
>> From scratch meaning glibc alone or the whole toolchain. I used
>> buildroot and glibc-dirclean to nuke entire glibc but gcc was not
>> rebuilt. I can try that too.
>
> No, rebuilding glibc from scratch should be fine.
Right, I clean built the entire toolchain and that didn't help - but turned out to
be sane thing anyways as installed headers seems were not rebuilt/installed and I
needed the signum.h -> signum-arch.h fixup in vfork.S
>> Some of the failed tests have prints about static TLS block ... so I'm
>> wondering if they could be related ?
>>
>> | $ cat dlfcn/tststatic.out
>> | .../build/libc.so.6: cannot allocate memory in static TLS block
>
> This suggests to me that the static initialization code does not produce
> sufficient alignment for the TCB, given the 32-byte alignment required
> by the rseq area.
>
> You could try and see what happens if you change
> sysdeps/arc/nptl/pthreaddef.h to this:
>
> /* Alignment requirement for TCB. */
> #define TCB_ALIGNMENT 32
>
> If that helps, we have more of a generic issue here. 8-/
Bingo, that fixes all the dlfcn/* failures (full testsuite still running)
PASS: dlfcn/tststatic
PASS: dlfcn/tststatic2
PASS: dlfcn/tststatic3
PASS: dlfcn/tststatic4
PASS: dlfcn/tststatic5
So is that the fix or more is needed ?
> The problem is that the TLS memory allocator does not add alignment
> padding on its own. This could meet additional alignment requirements
> if there is just one thread yet when higher-aligned TLS is loaded.
>
>> Also while we figure this out, does this prevent ARC port from being
>> committed.
>
> I don't think so. We just have to make sure that it does not block the
> release, i.e. resolve this during the next week or two. Do you think
> that would that be possible?
So it makes sens to commit ARC port now and your fix along the lines can then say
what it fixed in-tree.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-07-10 20:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 20:14 [PATCH v7 00/13] glibc port to ARC processors Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 01/13] ARC: ABI Implementation Vineet Gupta
2020-07-01 0:06 ` [PATCH v7.1 " Vineet Gupta
[not found] ` <b6322150-240a-5f06-b700-83e3eb79deec@linaro.org>
2020-07-01 19:36 ` Vineet Gupta
2020-07-01 19:45 ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 02/13] ARC: startup and dynamic linking code Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 03/13] ARC: Thread Local Storage support Vineet Gupta
2020-07-01 0:07 ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 04/13] ARC: Atomics and Locking primitives Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 05/13] ARC: math soft float support Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 06/13] ARC: hardware floating point support Vineet Gupta
2020-07-01 0:08 ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 07/13] ARC: Linux Syscall Interface Vineet Gupta
2020-07-01 0:08 ` [PATCH v7.1 " Vineet Gupta
[not found] ` <e9e2ae28-cd78-5924-c1fa-52b1499c245a@linaro.org>
2020-07-04 3:54 ` Vineet Gupta
2020-07-06 13:20 ` Adhemerval Zanella
2020-07-07 1:25 ` Vineet Gupta
2020-07-07 19:24 ` Adhemerval Zanella
2020-07-07 20:55 ` [PATCH v7.2 " Vineet Gupta
[not found] ` <b64d0df1-4229-d619-0ab1-ded287323775@linaro.org>
2020-07-08 19:32 ` Vineet Gupta
2020-07-09 16:03 ` Adhemerval Zanella
2020-07-09 16:24 ` Vineet Gupta
2020-07-09 16:25 ` Adhemerval Zanella
2020-07-09 21:13 ` Vineet Gupta
2020-07-09 21:36 ` ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface) Vineet Gupta
2020-07-09 22:01 ` Alistair Francis
2020-07-09 22:16 ` Vineet Gupta
2020-07-10 9:28 ` Florian Weimer
2020-07-10 15:53 ` Vineet Gupta
2020-07-10 17:02 ` Florian Weimer
2020-07-10 20:07 ` Vineet Gupta [this message]
2020-07-10 20:32 ` Florian Weimer
2020-07-10 19:12 ` Alistair Francis
2020-07-10 20:33 ` Florian Weimer
2020-07-10 20:56 ` Alistair Francis
2020-07-10 19:10 ` Alistair Francis
2020-07-07 21:07 ` [PATCH v7.1 07/13] ARC: Linux Syscall Interface Vineet Gupta
2020-07-07 21:32 ` Joseph Myers
2020-07-07 23:16 ` Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 08/13] ARC: Linux ABI Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 09/13] ARC: Linux Startup and Dynamic Loading Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 10/13] ARC: ABI lists Vineet Gupta
2020-07-01 0:09 ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 11/13] ARC: Build Infrastructure Vineet Gupta
2020-07-03 17:09 ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 12/13] build-many-glibcs.py: Enable ARC builds Vineet Gupta
2020-07-03 17:37 ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 13/13] Documentation for ARC port Vineet Gupta
2020-07-03 17:38 ` Adhemerval Zanella
2020-06-23 16:56 ` [PATCH v7 00/13] glibc port to ARC processors Vineet Gupta
2020-07-01 0:11 ` Vineet Gupta
2020-07-01 1:44 ` Adhemerval Zanella
2020-07-01 19:13 ` Vineet Gupta
2020-07-02 1:00 ` ARC math test regressions (was Re: [PATCH v7 00/13] glibc port to ARC processors) Vineet Gupta
2020-07-02 7:17 ` Andreas Schwab
2020-07-02 16:27 ` Joseph Myers
2020-07-02 17:45 ` Vineet Gupta
2020-07-02 21:27 ` [PATCH v7 00/13] glibc port to ARC processors Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2187d4-8383-8a8f-29ec-29c4b36007de@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).