* Re: [PATCH] crypto: md4: Fix checkpatch issues
[not found] <20230606112610.98149-1-franziska.naepelt@gmail.com>
@ 2023-06-06 12:14 ` Bagas Sanjaya
2023-06-06 12:18 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Bagas Sanjaya @ 2023-06-06 12:14 UTC (permalink / raw)
To: Franziska Naepelt, linux-crypto
Cc: herbert, davem, linux-kernel, Franziska Naepelt,
Linux SPDX Licenses, James Morris, Steve French
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
> The following checkpatch issues have been fixed:
> - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> - ERROR: space required after that ',' (ctx:VxV)
> - ERROR: space prohibited after that open square bracket '['
> - WARNING: space prohibited between function name and open parenthesis '('
> - ERROR: code indent should use tabs where possible
Again, please split up into one patch per fixes, as a patch series.
>
> not fixed:
> - ERROR: space required after that ',' (ctx:VxV)
> in lines: 64, 65, 66 have not ben fixed due to readability
Can you clearly explain why do you skip #define ROUNDx macros?
> -/*
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> * Cryptographic API.
> *
> * MD4 Message Digest Algorithm (RFC1320).
What about removing the license boilerplate text below (and thus convert
to SPDX)? Personally, I prefer having a SPDX conversion series for crypto/
directory instead.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: md4: Fix checkpatch issues
2023-06-06 12:14 ` [PATCH] crypto: md4: Fix checkpatch issues Bagas Sanjaya
@ 2023-06-06 12:18 ` Ard Biesheuvel
2023-06-06 12:22 ` Bagas Sanjaya
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2023-06-06 12:18 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Franziska Naepelt, linux-crypto, herbert, davem, linux-kernel,
Franziska Naepelt, Linux SPDX Licenses, James Morris,
Steve French
On Tue, 6 Jun 2023 at 14:15, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
> > The following checkpatch issues have been fixed:
> > - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> > - ERROR: space required after that ',' (ctx:VxV)
> > - ERROR: space prohibited after that open square bracket '['
> > - WARNING: space prohibited between function name and open parenthesis '('
> > - ERROR: code indent should use tabs where possible
>
> Again, please split up into one patch per fixes, as a patch series.
>
Apart from the SPDX conversion, I think it is fine to fix multiple
different whitespace issues in the same file with one patch. Splitting
that up is just busywork.
> >
> > not fixed:
> > - ERROR: space required after that ',' (ctx:VxV)
> > in lines: 64, 65, 66 have not ben fixed due to readability
>
> Can you clearly explain why do you skip #define ROUNDx macros?
>
> > -/*
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > * Cryptographic API.
> > *
> > * MD4 Message Digest Algorithm (RFC1320).
>
> What about removing the license boilerplate text below (and thus convert
> to SPDX)? Personally, I prefer having a SPDX conversion series for crypto/
> directory instead.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: md4: Fix checkpatch issues
2023-06-06 12:18 ` Ard Biesheuvel
@ 2023-06-06 12:22 ` Bagas Sanjaya
0 siblings, 0 replies; 3+ messages in thread
From: Bagas Sanjaya @ 2023-06-06 12:22 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Franziska Naepelt, linux-crypto, herbert, davem, linux-kernel,
Franziska Naepelt, Linux SPDX Licenses, James Morris,
Steve French
On 6/6/23 19:18, Ard Biesheuvel wrote:
> On Tue, 6 Jun 2023 at 14:15, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>>
>> On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
>>> The following checkpatch issues have been fixed:
>>> - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>>> - ERROR: space required after that ',' (ctx:VxV)
>>> - ERROR: space prohibited after that open square bracket '['
>>> - WARNING: space prohibited between function name and open parenthesis '('
>>> - ERROR: code indent should use tabs where possible
>>
>> Again, please split up into one patch per fixes, as a patch series.
>>
>
> Apart from the SPDX conversion, I think it is fine to fix multiple
> different whitespace issues in the same file with one patch. Splitting
> that up is just busywork.
>
Do you mean SPDX conversion in one patch and the rest in another? I think
so and confused...
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-06 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230606112610.98149-1-franziska.naepelt@gmail.com>
2023-06-06 12:14 ` [PATCH] crypto: md4: Fix checkpatch issues Bagas Sanjaya
2023-06-06 12:18 ` Ard Biesheuvel
2023-06-06 12:22 ` Bagas Sanjaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).