[PATCH] spi: mediatek: advertise the availability of Dual and Quad mode

[PATCH] spi: mediatek: advertise the availability of Dual and Quad mode

[qii.wang]

From: Qii Wang <qii.wang@mediatek.com>

this patch advertise the availability of Dual and Quad SPI mode
for ipm design.

Signed-off-by: Qii Wang <qii.wang@mediatek.com>
Signed-off-by: Tim.Kuo <Tim.kuo@mediatek.com>
---
 drivers/spi/spi-mt65xx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
index 21c321f43766..1501ee8459ff 100644
--- a/drivers/spi/spi-mt65xx.c
+++ b/drivers/spi/spi-mt65xx.c
@@ -1144,7 +1144,8 @@ static int mtk_spi_probe(struct platform_device *pdev)
 	if (mdata->dev_comp->must_tx)
 		master->flags = SPI_MASTER_MUST_TX;
 	if (mdata->dev_comp->ipm_design)
-		master->mode_bits |= SPI_LOOP;
+		master->mode_bits |= SPI_LOOP | SPI_RX_DUAL | SPI_TX_DUAL |
+				     SPI_RX_QUAD | SPI_TX_QUAD;
 
 	if (mdata->dev_comp->ipm_design) {
 		mdata->dev = dev;
-- 
2.25.1

Re: [PATCH] spi: mediatek: advertise the availability of Dual and Quad mode

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

On Tue, May 23, 2023 at 07:26:08PM +0800, qii.wang@mediatek.com wrote:

>  	if (mdata->dev_comp->ipm_design)
> -		master->mode_bits |= SPI_LOOP;
> +		master->mode_bits |= SPI_LOOP | SPI_RX_DUAL | SPI_TX_DUAL |
> +				     SPI_RX_QUAD | SPI_TX_QUAD;

I don't see any changes to handle these modes?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: mediatek: advertise the availability of Dual and Quad mode

[Qii Wang (王琪)]

On Tue, 2023-05-23 at 12:33 +0100, Mark Brown wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
The previous patch was this one: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/spi/spi-mt65xx.c?h=v6.4-rc3&id=9f763fd20da7d892ffaedac0c58d821922f8a674

Re: [PATCH] spi: mediatek: advertise the availability of Dual and Quad mode

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Thu, May 25, 2023 at 06:21:26AM +0000, Qii Wang (王琪) wrote:

> The previous patch was this one: 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/spi/spi-mt65xx.c?h=v6.4-rc3&id=9f763fd20da7d892ffaedac0c58d821922f8a674

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: mediatek: advertise the availability of Dual and Quad mode

[Mark Brown]

On Tue, 23 May 2023 19:26:08 +0800, qii.wang@mediatek.com wrote:
> this patch advertise the availability of Dual and Quad SPI mode
> for ipm design.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: mediatek: advertise the availability of Dual and Quad mode
      commit: dcb2d27444baeba91701bcab38d60c219cb47463

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark