From: Mark Brown <broonie@kernel.org>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de, linux-imx@nxp.com,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock
Date: Thu, 8 Apr 2021 14:43:47 +0100 [thread overview]
Message-ID: <20210408134347.GE4516@sirena.org.uk> (raw)
In-Reply-To: <20210408103347.244313-2-xiaoning.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
On Thu, Apr 08, 2021 at 06:33:47PM +0800, Clark Wang wrote:
> When some drivers use spi to send data, spi_transfer->speed_hz is
> not assigned. If spidev->max_speed_hz is not assigned as well, it
> will cause an error in configuring the clock.
> Add a check for these two values before configuring the clock. An
> error will be returned when they are not assigned.
For the case where the transfer speed is not set __spi_validate() will
take the controller's maximum speed so the controller should just be
able to unconditionally use the transfer's speed. Your issue is
therefore that the controllers are sometimes not setting a maximum
speed which this doesn't seem to fix AFAICT? I'd expect the driver to
be able to work one out based on the input clock.
> struct spi_imx_devtype_data {
> void (*intctrl)(struct spi_imx_data *, int);
> int (*prepare_message)(struct spi_imx_data *, struct spi_message *);
> - int (*prepare_transfer)(struct spi_imx_data *, struct spi_device *,
> - struct spi_transfer *);
> + int (*prepare_transfer)(struct spi_imx_data *, struct spi_device *);
> void (*trigger)(struct spi_imx_data *);
> int (*rx_available)(struct spi_imx_data *);
> void (*reset)(struct spi_imx_data *);
This seems to be a fairly big and surprising refactoring for the
described change. It's quite hard to tie the change to the changelog.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-08 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:33 [PATCH] spi: imx: add 16/32 bits per word support for slave mode Clark Wang
2021-04-08 10:33 ` [PATCH] spi: imx: add a check for speed_hz before calculating the clock Clark Wang
2021-04-08 13:43 ` Mark Brown [this message]
2021-04-08 14:05 ` Mark Brown
2021-04-09 16:22 ` Mark Brown
2021-05-24 8:25 ` [PATCH] spi: imx: add 16/32 bits per word support for slave mode Tomas Melin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408134347.GE4516@sirena.org.uk \
--to=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).