From: Tomas Melin <tomas.melin@vaisala.com>
To: Clark Wang <xiaoning.wang@nxp.com>,
broonie@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com
Cc: kernel@pengutronix.de, linux-imx@nxp.com,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: imx: add 16/32 bits per word support for slave mode
Date: Mon, 24 May 2021 11:25:28 +0300 [thread overview]
Message-ID: <961ec8d9-d96e-2dce-f2d0-b10299e10afb@vaisala.com> (raw)
In-Reply-To: <20210408103347.244313-1-xiaoning.wang@nxp.com>
Hi,
On 4/8/21 1:33 PM, Clark Wang wrote:
> Enable 16/32 bits per word support for spi-imx slave mode.
> It only support 8 bits per word in slave mode before.
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> drivers/spi/spi-imx.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 4fe767acaca7..24ba7ab1b05d 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -386,7 +386,12 @@ static void spi_imx_buf_tx_swap(struct spi_imx_data *spi_imx)
>
> static void mx53_ecspi_rx_slave(struct spi_imx_data *spi_imx)
> {
> - u32 val = be32_to_cpu(readl(spi_imx->base + MXC_CSPIRXDATA));
> + u32 val = readl(spi_imx->base + MXC_CSPIRXDATA);
> +
> + if (spi_imx->bits_per_word <= 8)
> + val = be32_to_cpu(val);
> + else if (spi_imx->bits_per_word <= 16)
> + val = (val << 16) | (val >> 16);
Would it be good to use available
spi_imx_buf_rx_u32
spi_imx_buf_rx_u16
spi_imx_buf_rx_u8
helpers here?
thanks,
Tomas
>
> if (spi_imx->rx_buf) {
> int n_bytes = spi_imx->slave_burst % sizeof(val);
> @@ -415,7 +420,11 @@ static void mx53_ecspi_tx_slave(struct spi_imx_data *spi_imx)
> if (spi_imx->tx_buf) {
> memcpy(((u8 *)&val) + sizeof(val) - n_bytes,
> spi_imx->tx_buf, n_bytes);
> - val = cpu_to_be32(val);
> + if (spi_imx->bits_per_word <= 8)
> + val = cpu_to_be32(val);
> + else if (spi_imx->bits_per_word <= 16)
> + val = (val << 16) | (val >> 16);
> +
> spi_imx->tx_buf += n_bytes;
> }
>
prev parent reply other threads:[~2021-05-24 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:33 [PATCH] spi: imx: add 16/32 bits per word support for slave mode Clark Wang
2021-04-08 10:33 ` [PATCH] spi: imx: add a check for speed_hz before calculating the clock Clark Wang
2021-04-08 13:43 ` Mark Brown
2021-04-08 14:05 ` Mark Brown
2021-04-09 16:22 ` Mark Brown
2021-05-24 8:25 ` Tomas Melin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961ec8d9-d96e-2dce-f2d0-b10299e10afb@vaisala.com \
--to=tomas.melin@vaisala.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).