[PATCH v2 0/2] nuvoton,wpcm450-fiu binding example fixes

[PATCH v2 0/2] nuvoton,wpcm450-fiu binding example fixes

[Jonathan Neuschäfer]

My recently merged nuvoton,wpcm450-fiu DT binding caused some
dt_binding_check issues in linux-next. This series attempts to fix them
before the breakage spreads any further.

Thanks to Rob Herring for running his dt_binding_check bot, and Conor
Dooley who notified me that the issue has reached linux-next.

v2:
- Some commit message improvements, as suggested by Krzysztof Kozlowski

Jonathan Neuschäfer (2):
  spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus
    include)
  spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing
    reg property)

 .../devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.35.1

[PATCH v2 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

[Jonathan Neuschäfer]

The nuvoton,wpcm450-fiu binding's example includes
nuvoton,wpcm450-clk.h, which has not been merged yet,
thus causing a dt_binding_check error on -next.

Fix this error by simply hardcoding the clock index in the example,
before the breakage spreads any further.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Reported-by: Rob Herring <robh@kernel.org>
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

v2:
- Credit Rob Herring as well (Rob's bot reported the issue, Conor made
  me aware that it is a problem that has found its way into linux-next)
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index ef94803e75d90..e4162845fcc1d 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -45,14 +45,13 @@ unevaluatedProperties: false

 examples:
   - |
-    #include <dt-bindings/clock/nuvoton,wpcm450-clk.h>
     spi@c8000000 {
       compatible = "nuvoton,wpcm450-fiu";
       reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
       #address-cells = <1>;
       #size-cells = <0>;
       reg-names = "control", "memory";
-      clocks = <&clk WPCM450_CLK_FIU>;
+      clocks = <&clk 0>;
       nuvoton,shm = <&shm>;

       flash@0 {
--
2.35.1

[PATCH v2 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)

[Jonathan Neuschäfer]

Add missing "reg = <0>;" property to the flash@0 node in the example.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

v2:
- depersonalize commit message
- Add Krzysztof's R-b
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index e4162845fcc1d..4e0d391e1d697 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -56,6 +56,7 @@ examples:

       flash@0 {
         compatible = "jedec,spi-nor";
+        reg = <0>;
       };
     };

--
2.35.1

Re: [PATCH v2 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)

[Geert Uytterhoeven]

On Tue, Nov 29, 2022 at 11:27 AM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Add missing "reg = <0>;" property to the flash@0 node in the example.
>
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>
> v2:
> - depersonalize commit message
> - Add Krzysztof's R-b

Thanks, this fixes "make dt_binding_check" for me, so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds